Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

WASM tests update #7018

Merged
merged 1 commit into from
Nov 12, 2017
Merged

WASM tests update #7018

merged 1 commit into from
Nov 12, 2017

Conversation

pepyakin
Copy link
Contributor

  • We no longer use legalization of JS FFI. Thus we can use i64 types in interfaces directly and we no longer need to use setTempRet0. Also, LTO have been enabled for the tests, so gas consumption improved a bit.
  • All libc related functions are now with prefix ext_, e.g. _malloc became _ext_malloc. This is needed to workaround some emscripten specific behavior and might change in the future.
  • New functions _ext_memmove and _ext_memset added.
  • mem_copy fixes. The arguments poped in a wrong order. Also make it really return a value, as LLVM really could use it sometimes.
  • Small improvement of a test ergonomics: gas checks are pushed to the end of the test functions.

@parity-cla-bot
Copy link

It looks like @pepyakin hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 10, 2017
@pepyakin
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @pepyakin signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 10, 2017
@NikVolf
Copy link
Contributor

NikVolf commented Nov 10, 2017

Already discussed and partially reviewed, so quick lgtm :)

@NikVolf NikVolf added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A8-looksgood 🦄 Pull request is reviewed well. and removed A8-looksgood 🦄 Pull request is reviewed well. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 11, 2017
@NikVolf NikVolf merged commit bcdfc50 into master Nov 12, 2017
@NikVolf NikVolf deleted the update-pwasm-std branch November 12, 2017 21:21
@5chdn 5chdn added this to the 1.9 milestone Nov 13, 2017
debris pushed a commit that referenced this pull request Nov 13, 2017
@debris debris mentioned this pull request Nov 13, 2017
@pepyakin pepyakin changed the title Wasm tests update WASM tests update Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants