This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix aura difficulty race #7198
Merged
Fix aura difficulty race #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
rphmeier
added
the
A8-backport 🕸
rphmeier
added
B0-patch
and removed
A8-backport 🕸
tomusdrw
approved these changes
Dec 5, 2017
| let step = self.step.load(); | ||
| let expected_diff = U256::from(U128::max_value()) + parent_step - step.into(); |
There was a problem hiding this comment.
Looks like the difficulty calcution is already copy pasted in couple of places, maybe we should extract it into a helper function?
tomusdrw
added
A8-looksgood 🦄
arkpar
reviewed
Dec 5, 2017
| let expected_diff = U256::from(U128::max_value()) + parent_step - step.into(); | ||
|
|
||
| if header.difficulty() != &expected_diff { | ||
| return Seal::None; |
There was a problem hiding this comment.
Would it make sense to seal and release a block with a previous step instead?
There was a problem hiding this comment.
This case can also only happen when update_sealing is called upon import of new best block from the prior step, but update_sealing also gets called when the step changes. So triggering sealing again for the correct step is unnecessary.
arkpar
added
A5-grumble 🔥
arkpar
added
A8-looksgood 🦄
tomusdrw
pushed a commit
that referenced
this pull request
Dec 7, 2017
* Fix Aura difficulty race * fix test key * extract out score calculation * fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this sequence of events was possible:
This might cause #6761 but will need further investigation.