This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
detect different node, same-key signing in aura #7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
rphmeier
added
A3-inprogress ⏳
rphmeier
added
A0-pleasereview 🤓
5chdn
added
A8-looksgood 🦄
5chdn
pushed a commit
that referenced
this pull request
Dec 15, 2017
* detect different node, same-key signing in aura * reduce scope of warning
Merged
tomusdrw
pushed a commit
that referenced
this pull request
Dec 28, 2017
* new warp enodes (#7287) * new warp enodes * added one more warp enode; replaced spaces with tabs * Bump beta to 1.8.5 * Update kovan boot nodes * detect different node, same-key signing in aura (#7245) * detect different node, same-key signing in aura * reduce scope of warning * Fix Cargo.lock * Updating mainnet bootnodes. * Update bootnodes (#7363) * Updating mainnet bootnodes. * Add additional parity-beta bootnodes. * Restore old parity bootnodes and update foudation bootnodes
tomusdrw
pushed a commit
that referenced
this pull request
Jan 8, 2018
* detect different node, same-key signing in aura * reduce scope of warning
5chdn
pushed a commit
that referenced
this pull request
Jan 8, 2018
* Merge pull request #7368 from paritytech/td-future-blocks Wait for future blocks in AuRa * Advance AuRa step as far as we can and prevent invalid blocks. (#7451) * Advance AuRa step as far as we can. * Wait for future blocks. * Problem: AuRa's unsafeties around step duration (#7282) Firstly, `Step.duration_remaining` casts it to u32, unnecesarily limiting it to 2^32. While theoretically this is "good enough" (at 3 seconds steps it provides room for a little over 400 years), it is still a lossy way to calculate the remaining time until the next step. Secondly, step duration might be zero, triggering division by zero in `Step.calibrate` Solution: rework the code around the fact that duration is typically in single digits and never grows, hence, it can be represented by a much narrower range (u16) and this highlights the fact that multiplying u64 by u16 will only result in an overflow in even further future, at which point we should panic informatively (if anybody's still around) Similarly, panic when it is detected that incrementing the step counter wrapped around on the overflow of usize. As for the division by zero, prevent it by making zero an invalid value for step duration. This will make AuRa log the constraint mismatch and panic (after all, what purpose would zero step duration serve? it makes no sense within the definition of the protocol, as finality can only be achieved as per the specification if messages are received within the step duration, which would violate the speed of light and other physical laws in this case). * Fix tests. * detect different node, same-key signing in aura (#7245) * detect different node, same-key signing in aura * reduce scope of warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add a helpful warning message after confusing a few of us :)