This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Expose default gas price percentile configuration in CLI #7497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
Merged
|
Are we sticking with 50 as default for now? |
andresilva
suggested changes
Jan 8, 2018
There was a problem hiding this comment.
The light client also needs to be updated (light/eth.rs and helpers/light_fetch.rs). Also update this comment please (https://github.com/paritytech/parity/pull/7497/files#diff-24a471dd84d14f563b041a9786723406R228)
| @@ -1546,6 +1552,7 @@ mod tests { | |||
| arg_tx_time_limit: Some(100u64), | |||
| arg_relay_set: "cheap".into(), | |||
| arg_min_gas_price: Some(0u64), | |||
| arg_gas_price_percentile: 50usize, | |||
There was a problem hiding this comment.
Maybe override the default for the test in tests/config.full.toml.
| assert_eq!(corpus.percentile(1), None); | ||
| assert_eq!(corpus.percentile(101), Some(&10)); | ||
| assert_eq!(corpus.percentile(100), Some(&10)); | ||
| assert_eq!(corpus.percentile(50), Some(&5)); |
There was a problem hiding this comment.
I think for a bigger data set this should be the same as median.
There was a problem hiding this comment.
We have even number of elements here.
NikVolf
added
A8-looksgood 🦄
folsen
approved these changes
Jan 9, 2018
andresilva
approved these changes
Jan 9, 2018
debris
approved these changes
Jan 9, 2018
debris
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Expose gas price percentile. * Fix light eth_call. * fix gas_price in light client
5chdn
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Merge pull request #7368 from paritytech/td-future-blocks Wait for future blocks in AuRa * Fix tracing failed calls. * Problem: sending any Whisper message fails The error is "PoW too low to compete with other messages" This has been previously reported in #7144 Solution: prevent the move semantics The source of the error is in PoolHandle.relay implementation for NetPoolHandle. Because of the move semantics, `res` variable is in fact copied (as it implements Copy) into the closure and for that reason, the returned result is always `false. * Merge pull request #7433 from paritytech/td-strict-config Strict config parsing * Problem: AuRa's unsafeties around step duration (#7282) Firstly, `Step.duration_remaining` casts it to u32, unnecesarily limiting it to 2^32. While theoretically this is "good enough" (at 3 seconds steps it provides room for a little over 400 years), it is still a lossy way to calculate the remaining time until the next step. Secondly, step duration might be zero, triggering division by zero in `Step.calibrate` Solution: rework the code around the fact that duration is typically in single digits and never grows, hence, it can be represented by a much narrower range (u16) and this highlights the fact that multiplying u64 by u16 will only result in an overflow in even further future, at which point we should panic informatively (if anybody's still around) Similarly, panic when it is detected that incrementing the step counter wrapped around on the overflow of usize. As for the division by zero, prevent it by making zero an invalid value for step duration. This will make AuRa log the constraint mismatch and panic (after all, what purpose would zero step duration serve? it makes no sense within the definition of the protocol, as finality can only be achieved as per the specification if messages are received within the step duration, which would violate the speed of light and other physical laws in this case). * Merge pull request #7437 from paritytech/a5-chains-expanse Remove expanse chain * Expanse Byzantium update w/ correct metropolis difficulty increment divisor (#7463) * Byzantium Update for Expanse Here the changes go. Hope I didnt miss anything. * expip2 changes - update duration limit * Fix missing EXPIP-2 fields * Format numbers as hex * Fix compilation errors * Group expanse chain spec fields together * Set metropolisDifficultyIncrementDivisor for Expanse * Revert #7437 * Add Expanse block 900_000 hash checkpoint * Advance AuRa step as far as we can and prevent invalid blocks. (#7451) * Advance AuRa step as far as we can. * Wait for future blocks. * fixed panic when io is not available for export block, closes #7486 (#7495) * Update Parity Mainnet Bootnodes (#7476) * Update Parity Mainnet Bootnodes * Replace the Azure HDD bootnodes with the new ones :) * Use https connection (#7503) Use https when connecting to etherscan.io API for price-info * Expose default gas price percentile configuration in CLI (#7497) * Expose gas price percentile. * Fix light eth_call. * fix gas_price in light client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.