This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
refactor stratum to remove retain cycle #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
Looks good.
Can be further simplified by using PubSub from jsonrpc instead of manually tracking peers.
In such case TCP dispatcher does not need to be exposed from the builder at all. You just use RequestContext::sender to have a reliable sink to the peer and also pub-sub handles disconnects/connection drops automatically (by calling unsubscribe handler).
tomusdrw
added
A7-looksgoodtestsfail 🤖
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #7823