This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fixed parsing ethash seals and verify_block_undordered #8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
rphmeier
reviewed
Mar 1, 2018
| @@ -439,18 +466,6 @@ impl Ethash { | |||
| } | |||
| } | |||
|
|
|||
| impl Header { | |||
There was a problem hiding this comment.
glad we can kill these impls
This was referenced Mar 1, 2018
Closed
gavofyork
approved these changes
Mar 1, 2018
gavofyork
added
A8-looksgood 🦄
5chdn
pushed a commit
that referenced
this pull request
Mar 5, 2018
Merged
andresilva
pushed a commit
that referenced
this pull request
Mar 5, 2018
Merged
debris
pushed a commit
that referenced
this pull request
Mar 5, 2018
tomusdrw
pushed a commit
that referenced
this pull request
Mar 14, 2018
* CI: Fix cargo cache (#7968) * Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows * fixed ethstore sign (#8026) * fixed parsing ethash seals and verify_block_undordered (#8031) * fix for verify_block_basic crashing on invalid transaction rlp (#8032) * fix cache & snapcraft CI build (#8052) after successful testing it is necessary to port in a ```beta``` and ```stable``` * Add MCIP-6 Byzyantium transition to Musicoin spec (#7841) * Add test chain spec for musicoin byzantium testnet * Add MCIP-6 Byzyantium transition to Musicoin spec * Update mcip6_byz.json * ethcore: update musicoin byzantium block number * ethcore: update musicoin byzantium block number * ethcore: update musicoin bootnodes * Update musicoin.json * Update musicoin.json * More bootnodes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlp::decodein unsafe, thereforeHeader::mix_hashandHeader::nonceare unsafe. Added a test forverify_block_unorderedwhich panicked when parsing seal with correct len, but invalid seal fields