This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[stable] Optimize JS build #8093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
amaury1093
reviewed
Mar 13, 2018
| @@ -38,7 +37,6 @@ function getPlugins (_isProd = isProd) { | |||
| const plugins = [ | |||
There was a problem hiding this comment.
getPlugins only takes 1 argument here, but has 2 when it's called.
There was a problem hiding this comment.
Good catch. Thanks! Leftovers from previous approach.
amaury1093
approved these changes
Mar 13, 2018
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces common chunk between
bundle.jsandembed.js(should save ~3MB)