This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Wasm runner fix #8236
Closed
Wasm runner fix #8236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread 'main' panicked at 'Wasm schedule expected to exist while checking wasm contract. Misconfigured client?', src/libcore/option.rs:891:5
lexfrl
added
A0-pleasereview 🤓
NikVolf
reviewed
Mar 27, 2018
| @@ -130,7 +130,7 @@ pub fn run_fixture(fixture: &Fixture) -> Vec<Fail> { | |||
| Err(e) => { return Fail::load(e); }, | |||
| }; | |||
|
|
|||
| let mut ext = FakeExt::new(); | |||
| let mut ext = FakeExt::new().with_wasm(); | |||
There was a problem hiding this comment.
It was already fixed, how diff comes up?..
NikVolf
reviewed
Mar 27, 2018
| @@ -41,8 +41,8 @@ pub struct Fixture { | |||
|
|
|||
| #[derive(Deserialize, Debug)] | |||
| pub struct StorageEntry { | |||
| pub key: Uint, | |||
There was a problem hiding this comment.
why? uint provide more flexibility, you don't need to write 0x0000000000000000..00000000 for 0x
There was a problem hiding this comment.
but with explicit H256 you’ll never mess up with endianess on converting to bytes
NikVolf
added
A4-gotissues 💥
5chdn
added
A1-onice 🌨
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a runtime error