Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add Ethereum Social support #8325

Merged
merged 1 commit into from Apr 9, 2018
Merged

Add Ethereum Social support #8325

merged 1 commit into from Apr 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2018

Ethereum Social (aka ETSC) is an ethereum-fork based blockchain platform for forum sites.

You can see the info about our coin on our homepage ethereumsocial.kr and korean forum site gazua.tv

Coin spec:

Homestead, EIP150, EIP160, ECIP1017, ECIP1041 enabled by default.
Based on go-social node.
Chainid and networkid is 0x1C.
Using the same hd wallet path with ethereum.
ps) You can see the network stats here and join mining here

@parity-cla-bot
Copy link

It looks like @akx20000a hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@ghost
Copy link
Author

ghost commented Apr 6, 2018

[clabot:check]

@parity-cla-bot
Copy link

It looks like @akx20000a signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@@ -76,6 +76,11 @@ pub fn new_easthub<'a, T: Into<SpecParams<'a>>>(params: T) -> Spec {
load(params.into(), include_bytes!("../../res/ethereum/easthub.json"))
}

/// Create a new Ethereum Social mainnet chain spec.
pub fn new_easthub<'a, T: Into<SpecParams<'a>>>(params: T) -> Spec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easthub?

Copy link
Author

@ghost ghost Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn Nah it should be ethereumsocial sorry 😅

@@ -294,7 +294,7 @@ usage! {

ARG arg_chain: (String) = "foundation", or |c: &Config| c.parity.as_ref()?.chain.clone(),
"--chain=[CHAIN]",
"Specify the blockchain type. CHAIN may be either a JSON chain specification file or olympic, frontier, homestead, mainnet, morden, ropsten, classic, expanse, musicoin, ellaism, easthub, testnet, kovan or dev.",
"Specify the blockchain type. CHAIN may be either a JSON chain specification file or olympic, frontier, homestead, mainnet, morden, ropsten, classic, expanse, musicoin, ellaism, easthub, ethereumsocial, testnet, kovan or dev.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is growing out of hand. we need some idea here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is not sustainable, maybe put some basics in there and then a reference to a full list somewhere else.

parity/params.rs Outdated
@@ -64,6 +65,7 @@ impl str::FromStr for SpecType {
"musicoin" => SpecType::Musicoin,
"ellaism" => SpecType::Ellaism,
"easthub" => SpecType::Easthub,
"ethereumsocial" => SpecType::Ethereumsocial,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethereum-social? EthereumSocial?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn EthereumSocial for capital, ethereumsocial for small letters 😄

@5chdn 5chdn added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. M2-config 📂 Chain specifications and node configurations. labels Apr 6, 2018
@5chdn 5chdn added this to the 1.11 milestone Apr 6, 2018
@5chdn 5chdn self-assigned this Apr 6, 2018
@ghost
Copy link
Author

ghost commented Apr 6, 2018

@5chdn Sorry for the copy-paste without testing it 😄 It is fixed and is now visible on stats.ethereumsocial.kr

@ghost
Copy link
Author

ghost commented Apr 6, 2018

Anyway, thanks for the lightning review ⚡️

@ghost
Copy link
Author

ghost commented Apr 6, 2018

merge

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Apr 9, 2018
@5chdn
Copy link
Contributor

5chdn commented Apr 9, 2018

Do you mind if we use "social" instead of "ethereumsocial"? We also use "classic" for Ethereum Classic. Not sure if this is ambiguous though...

@5chdn 5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Apr 9, 2018
@ghost
Copy link
Author

ghost commented Apr 9, 2018

@5chdn Well "social" will be more approachable since we use --social on multi-geth
Will change it right away 😄

@ghost
Copy link
Author

ghost commented Apr 9, 2018

@5chdn Now we are "social" ¯_(ツ)_/¯

@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Apr 9, 2018
@5chdn 5chdn merged commit d97cf34 into openethereum:master Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants