Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[stable] Backports #8449

Merged
merged 4 commits into from
Apr 20, 2018
Merged

[stable] Backports #8449

merged 4 commits into from
Apr 20, 2018

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Apr 20, 2018

…reum#8438)

* Remove unused appdirs dependency in CLI

* Use forked app_dirs crate for reverted Windows dir behavior
@sorpaas sorpaas added A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. labels Apr 20, 2018
@sorpaas sorpaas added this to the Patch milestone Apr 20, 2018
@5chdn
Copy link
Contributor

5chdn commented Apr 20, 2018

@5chdn 5chdn added A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. and removed A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. labels Apr 20, 2018
ordian and others added 2 commits April 20, 2018 19:08
* Improve VM executor stack size estimation rules

* typo: docs add "(Debug build)" comment

* Fix an off by one typo and set minimal stack size

This avoids the case if `depth_threshold == max_depth`. Usually setting stack size to zero will just rebound it to
platform minimal stack size, but we set it here just in case.

* Use saturating_sub to avoid potential overflow
@sorpaas
Copy link
Collaborator Author

sorpaas commented Apr 20, 2018

We need to update crossbeam to 0.3 if we want to apply #8439. Looks like that's harmless.

@5chdn
Copy link
Contributor

5chdn commented Apr 20, 2018

Thanks :)

@5chdn 5chdn merged commit 014d0ac into openethereum:stable Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants