Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Store morden db and keys in "path/to/parity/data/Morden" (ropsten uses "test", like before) #8621

Merged
merged 2 commits into from
May 15, 2018
Merged

Store morden db and keys in "path/to/parity/data/Morden" (ropsten uses "test", like before) #8621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d52042
Store morden db and keys in "path/to/parity/data/Morden" (ropsten use…
dvdplm May 14, 2018
b94cb93
Lower case dataDir: "morden"
dvdplm May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethcore/res/ethereum/morden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Morden",
"dataDir": "test",
"dataDir": "Morden",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to lower-case name morden to keep it consistent with other chain configs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorpaas you are referring to "dataDir" right? If, that's the case I totally agree:

classic.json:3: "dataDir": "classic",
easthub.json:3:  "dataDir": "easthub",
ellaism.json:3:  "dataDir": "ellaism",
expanse.json:3: "dataDir": "expanse",
foundation.json:3:      "dataDir": "ethereum",
kovan.json:3:   "dataDir": "kovan",
kovan_wasm_test.json:3: "dataDir": "kovan-test",
mcip3_test.json:3:  "dataDir":"mcip3test",
mcip6_byz.json:3:  "dataDir":"mcip6test",
morden.json:3:  "dataDir": "test",
musicoin.json:3:  "dataDir":"musicoin",
ropsten.json:3: "dataDir": "test",
social.json:3:  "dataDir": "social",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. :)

"engine": {
"Ethash": {
"params": {
Expand Down
6 changes: 3 additions & 3 deletions util/dir/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ impl Directories {
DatabaseDirectories {
path: self.db.clone(),
legacy_path: self.base.clone(),
genesis_hash: genesis_hash,
fork_name: fork_name,
spec_name: spec_name,
genesis_hash,
fork_name,
spec_name,
}
}

Expand Down