Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[stable] Backports #8782

Merged
merged 7 commits into from
Jun 4, 2018
Merged

[stable] Backports #8782

merged 7 commits into from
Jun 4, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Jun 4, 2018

tomaka and others added 6 commits June 4, 2018 12:38
* Fix #8468

* Use U256::max_value() instead

* Fix again

* Also change initial transaction gas
Since we start parity with the UI disabled per default now, opening the browser post installation will show an annoying error message, confusing the user. This patch removes opening the browser to prevent that annoyance.

fixes #8194
* Set the request index to that of the current request

When setting up the chain of (two) requests to look up a block by hash, the second need to refer to the first. This fixes an issue where the back ref was set to the subsequent request, not the current one. When the requests are executed we loop through them in order and ensure the requests that should produce headers all match up. We do this by index so they better be right.

In other words: off by one.
* network-devp2p: sort nodes in node table using last contact data

* network-devp2p: rename node contact types in node table json output

* network-devp2p: fix node table tests

* network-devp2p: note node failure when failed to establish connection

* network-devp2p: handle UselessPeer error

* network-devp2p: note failure when marking node as useless
@andresilva andresilva added the A8-backport 🕸 Pull request is already reviewed well in another branch. label Jun 4, 2018
@andresilva
Copy link
Contributor Author

Need to fix #8682, don't merge this yet.

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Jun 4, 2018
@5chdn 5chdn added this to the Patch milestone Jun 4, 2018
@andresilva andresilva removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jun 4, 2018
@andresilva
Copy link
Contributor Author

I just tested and the signer is working properly.

@5chdn 5chdn mentioned this pull request Jun 4, 2018
57 tasks
@5chdn
Copy link
Contributor

5chdn commented Jun 4, 2018

Merging latest stable should resolve the issues.

@5chdn 5chdn merged commit c7202a7 into stable Jun 4, 2018
@5chdn 5chdn deleted the andre-stable-backports branch June 4, 2018 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants