This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
rpc: fix address formatting in TransactionRequest Display #8786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A2-insubstantial 👶
niklasad1
reviewed
Jun 4, 2018
| @@ -69,14 +69,16 @@ impl fmt::Display for TransactionRequest { | |||
| f, | |||
| "{} ETH from {} to 0x{:?}", | |||
| Colour::White.bold().paint(format_ether(eth)), | |||
| Colour::White.bold().paint(format!("0x{:?}", self.from)), | |||
| Colour::White.bold().paint( | |||
| self.from.as_ref().map(|f| format!("0x{:?}", f)).unwrap_or("?".to_string())), | |||
There was a problem hiding this comment.
unwrap_or_else(|| "?".into())
niklasad1
reviewed
Jun 4, 2018
| to | ||
| ), | ||
| None => write!( | ||
| f, | ||
| "{} ETH from {} for contract creation", | ||
| Colour::White.bold().paint(format_ether(eth)), | ||
| Colour::White.bold().paint(format!("0x{:?}", self.from)), | ||
| Colour::White.bold().paint( | ||
| self.from.as_ref().map(|f| format!("0x{:?}", f)).unwrap_or("?".to_string())), |
There was a problem hiding this comment.
unwrap_or_else(|| "?".into())
niklasad1
suggested changes
Jun 4, 2018
niklasad1
approved these changes
Jun 4, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 6, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: Remove UI related settings from CLI (openethereum#8783) Remove windows tray and installer (openethereum#8778) docs: add changelogs for 1.10.6 and 1.11.3 (openethereum#8810) Fix ancient blocks queue deadlock (openethereum#8751) Disallow unsigned transactions in case EIP-86 is disabled (openethereum#8802) Fix evmbin compilation (openethereum#8795) Have space between feature cfg flag (openethereum#8791) rpc: fix address formatting in TransactionRequest Display (openethereum#8786)
dvdplm
added a commit
that referenced
this pull request
Jun 7, 2018
…eric * origin/master: ethcore: fix ancient block error msg handling (#8832) CI: Fix docker tags (#8822) parity: fix indentation in sync logging (#8794) Removed obsolete IpcMode enum (#8819) Remove UI related settings from CLI (#8783) Remove windows tray and installer (#8778) docs: add changelogs for 1.10.6 and 1.11.3 (#8810) Fix ancient blocks queue deadlock (#8751) Disallow unsigned transactions in case EIP-86 is disabled (#8802) Fix evmbin compilation (#8795) Have space between feature cfg flag (#8791) rpc: fix address formatting in TransactionRequest Display (#8786) Conditionally compile ethcore public test helpers (#8743) Remove Result wrapper from AccountProvider in RPC impls (#8763) Update `license header` and `scripts` (#8666)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the from address looked using the signer cli: