This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Clearing up the reason behind "Ethereum Signed Message" #8828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @elichai hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
|
[clabot:check]. |
|
It looks like @elichai signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
5chdn
added
A2-insubstantial 👶
sorpaas
approved these changes
Jun 8, 2018
5chdn
reviewed
Jun 8, 2018
rpc/src/v1/helpers/dispatch.rs
Outdated
| @@ -237,7 +237,7 @@ pub fn fetch_gas_price_corpus( | |||
|
|
|||
| /// Returns a eth_sign-compatible hash of data to sign. | |||
| /// The data is prepended with special message to prevent | |||
| /// chosen-plaintext attacks. | |||
| /// malicious DApps from using the function to sign forge transactions. | |||
There was a problem hiding this comment.
Fixed. Don't know how it happened 👍
niklasad1
reviewed
Jun 10, 2018
rpc/src/v1/helpers/dispatch.rs
Outdated
| @@ -223,7 +223,7 @@ pub fn fetch_gas_price_corpus( | |||
| .map(move |prices| { | |||
| // produce a corpus from the vector and cache it. | |||
| // It's later used to get a percentile for default gas price. | |||
| let corpus: ::stats::Corpus<_> = prices.into(); | |||
| let corpus: ::stats::Corpus<_> =forge prices.into(); | |||
There was a problem hiding this comment.
I guess this is mistake?
niklasad1
suggested changes
Jun 10, 2018
niklasad1
added
the
A5-grumble 🔥
elichai
force-pushed
the
master
branch
2 times, most recently
from
bb675e4
to
46bf82e
Compare
|
Reverted. now it's good and clean. |
niklasad1
approved these changes
Jun 10, 2018
niklasad1
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jun 11, 2018
* master: Fix subcrate test compile (#8862) network-devp2p: downgrade logging to debug, add target (#8784) Clearing up a comment about the prefix for signing (#8828) Disable parallel verification and skip verifiying already imported txs. (#8834) devp2p: Move UDP socket handling from Discovery to Host. (#8790) Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803) Specify critical release flag per network (#8821) Fix `deadlock_detection` feature branch compilation (#8824) Use system allocator when profiling memory (#8831) added from and to to Receipt (#8756)
tavakyan
referenced
this pull request
in C4Coin/c4coin-parity
Jun 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this makes more sense.
First because there aren't really chosen-plaintext attacks against asymmetric encryption keys out there.
Second because faking a transaction to be signed by the user is a viable attack vector.