This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Print public key of the SS node on start #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
niklasad1
approved these changes
Jun 22, 2018
dvdplm
approved these changes
Jun 22, 2018
| @@ -165,6 +161,11 @@ mod server { | |||
| None => return Err("self secret is required when using secretstore".into()), | |||
| }; | |||
|
|
|||
| info!("Starting SecretStore node: {}", White.bold().paint(format!("{:?}", self_secret.public()))); | |||
There was a problem hiding this comment.
How about being explicit here and say Starting SecretStore node with pub key: {}?
There was a problem hiding this comment.
I'd like to keep it as short as possible (this line is already too long) - not sure if that gives any additional information :) But could replace, if you insist it is better :)
5chdn
added
A8-looksgood 🦄
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 27, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: deps: bump fs-swap (openethereum#8953) Eliminate some more `transmute()` (openethereum#8879) Restrict vault.json permssion to owner and using random suffix for temp vault.json file (openethereum#8932) print SS.self_public when starting SS node (openethereum#8949) scripts: minor improvements (openethereum#8930) rpc: cap gas limit of local calls (openethereum#8943) docs: update changelogs (openethereum#8931) ethcore: fix compilation when using slow-blocks or evm-debug features (openethereum#8936) fixed blooms dir creation (openethereum#8941) Update hardcoded headers (openethereum#8925)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
self_secretconfig option could be: a 64-char secret key or the 40-char address of the account (on this node) that is used to sign/encrypt messages.Getting the node' public key is especially hard in the 2nd case - afaik we do not have an RPC for getting the account public (it could be recovered from the signature, but it is too hard anyway). So I usually use
./ethstore public <address>in my scripts. But as @Tbaut has suggested it still isn't the best way to describe in the private transactions tutorial. So I suggest to print it on start (similar to how we're printing enode). This is for--features secretstoreonly, so won't spoil usual output: