This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Tentative fix for missing dependency error #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A0-pleasereview 🤓
sorpaas
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
👍 I missed this in #8944.
tempdir is not used in a normal build, but it's used by test build and test-helpers feature. We cannot specify optional dependencies for [cfg(test)], so having it declared twice in dependencies and dev-dependencies is valid.
CI testing always pulls the test-helpers feature, so this issue wasn't visible there.
|
@sorpaas do you know why CI is failing on this PR? I'm kind of lost as to what my be causing the multiple ribs other than "features something"... |
debris
approved these changes
Jun 26, 2018
debris
added
A7-looksgoodtestsfail 🤖
|
Please rebase on latest master to fix CI. |
* master: Refactor evm Instruction to be a c-like enum (#8914) Fix deadlock in blockchain. (#8977) snap: downgrade rust to revision 1.26.2, ref snapcraft/+bug/1778530 (#8984) Use local parity-dapps-glue instead of crate published at crates.io (#8983) parity: omit redundant last imported block number in light sync informant (#8962) Disable hardware-wallets on platforms that don't support `libusb` (#8464) Bump error-chain and quick_error versions (#8972)
5chdn
added
A8-looksgood 🦄
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jul 9, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: parity: fix db path when migrating to blooms db (openethereum#8975) Preserve the current abort behavior (openethereum#8995) Improve should_replace on NonceAndGasPrice (openethereum#8980) Tentative fix for missing dependency error (openethereum#8973)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent merge seems to have broken the dependency resolution. The
tempdircrate is needed for a normal build, not optional.