Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

nonroot CentOS Docker image #9280

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Conversation

JohnnySheffield
Copy link
Contributor

@niklasad1 @General-Beck Continuation of #9231, but with a much cleaner commit history.

@parity-cla-bot
Copy link

It looks like @JohnnySheffield signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

Copy link
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good! just a couple of questions :)

@@ -0,0 +1,25 @@
FROM centos:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file called build.Dockerfile? Is it a common convention? (I'm not a docker expert)

Copy link
Contributor Author

@JohnnySheffield JohnnySheffield Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename it to Dockerfile.build, short google search points that Dockerfile.build is some kind of convention

edit: this dockerfile is just a transitional image, so we must differentiate it somehow - hence Dockerfile.build. Once this image is built, we just extract the Parity binary from it, and build the final image using Dockerfile.


RUN yum -y update && \
yum install -y systemd-devel git make gcc-c++ gcc file binutils && \
curl -L "https://cmake.org/files/v3.12/cmake-3.12.0-Linux-x86_64.tar.gz" -o cmake.tar.gz && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not yum install cmake ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yum install cmake installs cmake 2.x, but then parity build fails as it needs 3.x, so i decided to install cmake directly. Ideally i would like to get it with yum, but had no luck

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system. labels Aug 7, 2018
@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
@5chdn 5chdn merged commit 31291eb into openethereum:master Aug 24, 2018
dvdplm added a commit that referenced this pull request Aug 30, 2018
* master:
  evmbin: Fix gas_used issue in state root mismatch and handle output better (#9418)
  Update hardcoded sync (#9421)
  Add block reward contract config to ethash and allow off-chain contracts (#9312)
  Private packets verification and queue refactoring (#8715)
  Update tobalaba.json (#9419)
  docs: add parity ethereum logo to readme (#9415)
  build: update rocksdb crate (#9414)
  Updating the CI system  (#8765)
  Better support for eth_getLogs in light mode (#9186)
  Add update docs script to CI (#9219)
  `gasleft` extern implemented for WASM runtime (kip-6) (#9357)
  block view! removal in progress (#9397)
  Prevent sync restart if import queue full (#9381)
  nonroot CentOS Docker image (#9280)
  ethcore: kovan: delay activation of strict score validation (#9406)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants