-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
It looks like @JohnnySheffield signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good! just a couple of questions :)
docker/centos/build.Dockerfile
Outdated
@@ -0,0 +1,25 @@ | |||
FROM centos:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file called build.Dockerfile
? Is it a common convention? (I'm not a docker expert)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename it to Dockerfile.build, short google search points that Dockerfile.build is some kind of convention
edit: this dockerfile is just a transitional image, so we must differentiate it somehow - hence Dockerfile.build. Once this image is built, we just extract the Parity binary from it, and build the final image using Dockerfile.
docker/centos/build.Dockerfile
Outdated
|
||
RUN yum -y update && \ | ||
yum install -y systemd-devel git make gcc-c++ gcc file binutils && \ | ||
curl -L "https://cmake.org/files/v3.12/cmake-3.12.0-Linux-x86_64.tar.gz" -o cmake.tar.gz && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not yum install cmake
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yum install cmake installs cmake 2.x, but then parity build fails as it needs 3.x, so i decided to install cmake directly. Ideally i would like to get it with yum, but had no luck
* master: evmbin: Fix gas_used issue in state root mismatch and handle output better (#9418) Update hardcoded sync (#9421) Add block reward contract config to ethash and allow off-chain contracts (#9312) Private packets verification and queue refactoring (#8715) Update tobalaba.json (#9419) docs: add parity ethereum logo to readme (#9415) build: update rocksdb crate (#9414) Updating the CI system (#8765) Better support for eth_getLogs in light mode (#9186) Add update docs script to CI (#9219) `gasleft` extern implemented for WASM runtime (kip-6) (#9357) block view! removal in progress (#9397) Prevent sync restart if import queue full (#9381) nonroot CentOS Docker image (#9280) ethcore: kovan: delay activation of strict score validation (#9406)
@niklasad1 @General-Beck Continuation of #9231, but with a much cleaner commit history.