Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add EOS Classic network support #9529

Closed
wants to merge 1 commit into from
Closed

Add EOS Classic network support #9529

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2018

EOS Classic is a combination of ETH & EOS protocol network

We would like to request adding EOS Classic Mainnet support on parity-ethereum client

Coin info

PR changes

  • Added EOSC Bootnodes from go-eosclassic
  • Added NewEOSC Hardfork logic
  • Tested with rust-eosclassic
  • Apply EOSC-1017 Reward

cc @5chdn @sorpaas @Tbaut @andresilva

[EOSC] Add EOS Classic support
2c4ffc3 
+ Added EOSC Bootnodes from go-eosclassic
+ Added NewEOSC Hardfork logic
+ Tested with rust-eosclassic
+ Apply EOSC-1017 Reward
@parity-cla-bot
Copy link

It looks like @eosclassicteam signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

sorpaas
sorpaas suggested changes Sep 11, 2018
View reviewed changes
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment for Callisto PR: #9445 (comment)

Please remove eoscTreasury/eoscStake/neweosc configs and use blockRewardContractCode config. Let me know if you have issues writing the block reward contract, I'm happy to help. (But please understand that we can't write the contract for you.)

@sorpaas sorpaas added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M2-config 📂 Chain specifications and node configurations. labels Sep 11, 2018
@sorpaas sorpaas modified the milestones: 2.1, 2.2 Sep 11, 2018
@ghost
Copy link
Author

ghost commented Sep 11, 2018

@sorpaas Thanks for your comment, may I ask if reward contract is compatible with geth? ( Or should I deploy it somewhere? )

@sorpaas
Copy link
Collaborator

sorpaas commented Sep 11, 2018

It's geth-compatible. You won't need to deploy the reward contract anywhere. Simply calculate the correct block rewards and embed the resulting EVM contract code to blockRewardContractCode param.

@5chdn 5chdn mentioned this pull request Sep 12, 2018
Merged
@5chdn
Copy link
Contributor

5chdn commented Sep 12, 2018

Block reward contract is documented here: https://wiki.parity.io/Block-Reward-Contract

@5chdn 5chdn added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Sep 18, 2018
@5chdn
Copy link
Contributor

5chdn commented Sep 18, 2018

Please reopen once ready.

@5chdn 5chdn closed this Sep 18, 2018
@andresilva
Copy link
Contributor

You can find an example of using the block reward contract in #9605 to implement the Musicoin block reward logic, there's also a gist there with instructions on how to build the contract.

@ghost
Copy link
Author

ghost commented Sep 20, 2018

@andresilva Well I know how to build a contract but thanks for your help 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@parity-cla-bot @sorpaas @5chdn @andresilva