Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Simultaneous platform tests WIP #9557

Merged
merged 9 commits into from
Sep 14, 2018
Merged

Simultaneous platform tests WIP #9557

merged 9 commits into from
Sep 14, 2018

Conversation

gabreal
Copy link
Contributor

@gabreal gabreal commented Sep 13, 2018

please see how builds could work for testing in parallel.
macos looks pretty slow.

@parity-cla-bot
Copy link

It looks like @gabreal signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

if [ "${RUST_FILES_MODIFIED}" = "0" ]
then
echo "__________Skipping Rust tests since no Rust files modified__________";
exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a nicer way to do this? "no files modified" is a valid result and should not result in a failing job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately not. will only become very unbeautiful. so i removed the check stage again. but builds take way to long IMHO before switching to it. Also there are errors in the stage within the CI as well as Rust code that does not seem to compile properly on all platforms.

@5chdn 5chdn added this to the 2.2 milestone Sep 14, 2018
@5chdn 5chdn added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. M1-ci 🙉 Continuous integration. labels Sep 14, 2018
@gabreal
Copy link
Contributor Author

gabreal commented Sep 14, 2018

Stages still need to be debugged, prob one could add allow_failure directives for some platforms.

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Sep 14, 2018
Copy link
Contributor

@General-Beck General-Beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all this should be done only for nightly.
Adnd add changes https://github.com/paritytech/parity-ethereum/blob/master/scripts/gitlab/push.sh#L55

@5chdn 5chdn merged commit 870ec89 into master Sep 14, 2018
@5chdn 5chdn deleted the platform-tests branch September 14, 2018 13:55
ordian added a commit to ordian/parity that referenced this pull request Sep 15, 2018
…-fix-windows

* 'master' of https://github.com/paritytech/parity:
  while working on the platform tests make them non-breaking (openethereum#9563)
  Improve P2P discovery (openethereum#9526)
  move dockerfile for android build container to scripts repo (openethereum#9560)
  Simultaneous platform tests WIP (openethereum#9557)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants