Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backports for 2.1.1 beta #9599

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Backports for 2.1.1 beta #9599

merged 3 commits into from
Sep 19, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Sep 19, 2018 •
edited
Loading

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. A8-backport 🕸 Pull request is already reviewed well in another branch. M1-ci 🙉 Continuous integration. M2-config 📂 Chain specifications and node configurations. labels Sep 19, 2018
@5chdn 5chdn added this to the Patch milestone Sep 19, 2018
@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Sep 19, 2018
@5chdn 5chdn merged commit cb09330 into beta Sep 19, 2018
@5chdn 5chdn deleted the a5-adkhsg branch September 19, 2018 18:31
c0deright
c0deright reviewed Sep 27, 2018
View reviewed changes
Copy link

@c0deright c0deright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use ^v2 instead of ^v2.*$ which should be the same?
It's not useful to use *$ if you don't backreference it.
Maybe you meant ^v2\.?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0deright c0deright c0deright left review comments

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M1-ci 🙉 Continuous integration. M2-config 📂 Chain specifications and node configurations. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.
4 participants
@5chdn @sorpaas @c0deright @ordian