Adds cli interface to allow reseting chain to a particular block #9782

seunlanlege · 2018-10-19T16:10:14Z

added BlockChainReset trait, client impl, and cli interface(?)

closes #8259

parity-cla-bot · 2018-10-19T16:10:16Z

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ethcore/src/client/client.rs

5chdn · 2018-12-14T13:49:18Z

Are you still working on that?

seunlanlege · 2018-12-17T09:42:01Z

currently blocked on #9910

tomusdrw · 2018-12-17T09:43:45Z

@seunlanlege can we add a TODO and get this one merged so that it's not blocked?

seunlanlege · 2018-12-17T09:45:42Z

yeah sure

5chdn · 2018-12-28T13:12:14Z

@dvdplm @tomusdrw could you review this?

tomusdrw

few more grumbles

ethcore/src/blockchain/blockchain.rs

ethcore/src/client/client.rs

parity/cli/mod.rs

parity/configuration.rs

ethcore/src/blockchain/blockchain.rs

niklasad1 · 2019-01-03T09:30:06Z

ethcore/src/client/client.rs

+				.bold()
+				.paint(format!("{:#?}", hashes))
+		);
+


I think this should be either debug or trace instead of info. Can you explain why it is info?

I'm using info because i need to communicate to the user which blocks are being deleted.

the user shouldn't need to run parity with -l trace or debug to see it

niklasad1

LGTM, just a question on the logging level

… in db, better cli interface

Co-Authored-By: seunlanlege <seunlanlege@gmail.com>

tomusdrw

lgtm, tiny grumble on making the argument required instead of panicking when not provided.

parity/cli/mod.rs

5chdn · 2019-01-16T11:19:54Z

Can we get docs for this?

sorpaas · 2019-01-16T17:42:55Z

ethcore/src/client/mod.rs

@@ -37,7 +37,8 @@ pub use self::test_client::{TestBlockChainClient, EachBlockWith};
 pub use self::chain_notify::{ChainNotify, NewBlocks, ChainRoute, ChainRouteType, ChainMessageType};
 pub use self::traits::{
    Nonce, Balance, ChainInfo, BlockInfo, ReopenBlock, PrepareOpenBlock, CallContract, TransactionInfo, RegistryInfo, ScheduleInfo, ImportSealedBlock, BroadcastProposalBlock, ImportBlock,
-    StateOrBlock, StateClient, Call, EngineInfo, AccountData, BlockChain, BlockProducer, SealedBlockImporter, BadBlocks,
+    StateOrBlock, StateClient, Call, EngineInfo, AccountData, BlockChain, BlockProducer, SealedBlockImporter,


Not introduced by this PR, but those three lines should all use tab for indentation.

…nethereum#9782) * added BlockChainReset trait, client impl, and cli interface * show block hashes to be deleted and new best block, update best block in db, better cli interface * delete BlockNumber from COL_EXTRA * add TODO comment * add BlockReciepts to imports * refactor block_headers_from_best_block, better cli documentation * exit gracefully if reset arg isn't supplied * fix cli usage macro * removed stray int literals * use Vec::with_capacity Co-Authored-By: seunlanlege <seunlanlege@gmail.com> * cast n to usize * correct imports * make db reset arg required

stone212 · 2020-01-25T07:11:31Z

Excellent tool! Is there a doc/example of actual usage?

zemse · 2020-05-01T14:47:35Z

You have to run this command:

parity --config <path-to-config-file> db reset <number-of-blocks-to-delete>

This command needs a config file of your network. In case you don't have, you might have to use a --chain ethereum or --chain kovan instead of --config.

And example of the output is here:

$ parity --config config.toml db reset 10
    Finished dev [unoptimized + debuginfo] target(s) in 0.30s
     Running `/home/ubuntu/openethereum/target/debug/parity --config config.toml db reset 10`
Loading config file from config.toml
2020-05-01 14:21:56 UTC Running AuRa with an even number of validators (4) is not recommended (risk of network split).
2020-05-01 14:21:56 UTC Not preparing block; cannot sign.
2020-05-01 14:21:56 UTC Configured for Era_Swap_Network using AuthorityRound engine
2020-05-01 14:21:57 UTC Deleting block hashes [
    0x7305578867f56a3fdb1ac2b289741f62adefd900abb54e892830c1668bbb702d,
    0xe2228b860e846e121041b2d3968cf49dcd487f7d25ce71b8c7c677a2c0d5e025,
    0xc9b46799cfe9c37d2ac77a9771a8b0ea5a62e19f94afb39802323a73c4982a76,
    0xf1ae9013b82639c4b26af72b7f727336c968df2bd6ac4d23e764e59ce7c9c3f6,
    0x7942ceca1dbf8b85c197101baaaae1d8e72a1b1aa6554dd0fb362fa5e8b449d9,
    0xd79457d65a1ab7a705ba70d1d6f66e5ad3840a7e9c414ece7388448db5a690df,
    0x98d7188cc3ab7ea6b966f26f0cd0a8426969596e0df4643bd3ffbc9e3f3ba85a,
    0x5835e92e18a2448a15e344e76b61db462abc8943c90d9d634ba3fc531d9bb543,
    0x767d30605c8f31dcf450c9eee6819dc761dc9853c7064ff8dd522834d4931e28,
    0xd69093df9b6ed319ef89877bafbe44c08088e9db1dad26e7180c96e5f26c5c19,
]
2020-05-01 14:21:57 UTC New best block hash 0x1eb6a246f3fdbfcd965d74547dc5a7b20eb59332d5ba21ca1d5f58df60fb4923
2020-05-01 14:21:57 UTC Successfully reset db!

I had to go through the commits to guess how it works.

dvdplm · 2020-05-01T14:53:16Z

You don't technically need a config file and openethereum db reset 123 works fine and will use the defaults (i.e. mainnet). You can use a config file if you want, or command line switches. This is consistent with all commands and not special for db reset.
Running openethereum --help will print the inline help for the command.

astudnev · 2020-06-01T09:35:34Z

After deleting twice 128 blocks i get error

2020-06-01 09:34:42 UTC State root not found for block #10500800 (d5c14706ef0a294b561e5037cb846047993da7c42af676986ea0c9ba9665d636)


====================

   0: panic_hook::gen_panic_msg
   1: panic_hook::set_with::{{closure}}
   2: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:474
   3: rust_begin_unwind
             at src/libstd/panicking.rs:378
   4: core::panicking::panic_fmt
             at src/libcore/panicking.rs:85
   5: core::option::expect_none_failed
             at src/libcore/option.rs:1211
   6: ethcore::client::client::Client::latest_state_and_header
   7: ethcore::client::client::Client::state_at
   8: <ethcore::client::client::Client as ethcore_call_contract::call_contract::CallContract>::call_contract
   9: registrar::registrar::RegistrarClient::get_address
  10: <ethcore_private_tx::key_server_keys::SecretStoreKeys<C> as ethcore_private_tx::key_server_keys::KeyProvider>::update_acl_contract
  11: ethcore_private_tx::Provider::new
  12: ethcore_service::service::ClientService::start
  13: openethereum::run::execute_impl
  14: openethereum::main_direct
  15: openethereum::main
  16: std::rt::lang_start::{{closure}}
  17: main
  18: __libc_start_main
  19: _start


Thread 'main' panicked at 'State root of best block header always valid.: InvalidStateRoot(0xc7e3ff48be7b6ce8734c52353b13bedc095ec6235c27e3235f6e71421aa05326)', ethcore/src/client/client.rs:1043

This is a bug. Please report it at:

    https://github.com/openethereum/openethereum/issues/new

seunlanlege requested review from dvdplm and tomusdrw October 19, 2018 16:10

seunlanlege changed the title ~~Adds cli interface to allow reseting chain to a particular block~~ (WIP) Adds cli interface to allow reseting chain to a particular block Oct 19, 2018

seunlanlege added A0-pleasereview 🤓 Pull request needs code review. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Oct 19, 2018

seunlanlege commented Oct 19, 2018

View reviewed changes

ethcore/src/client/client.rs Show resolved Hide resolved

5chdn added this to the 2.2 milestone Oct 24, 2018

5chdn removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Oct 26, 2018

5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018

sorpaas added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 25, 2018

5chdn added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Dec 14, 2018

seunlanlege changed the title ~~(WIP) Adds cli interface to allow reseting chain to a particular block~~ Adds cli interface to allow reseting chain to a particular block Dec 21, 2018

seunlanlege added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. labels Dec 21, 2018

seunlanlege force-pushed the reset-blockchain branch from d2f8949 to 82cfd95 Compare December 21, 2018 10:58

tomusdrw reviewed Dec 28, 2018

View reviewed changes

seunlanlege force-pushed the reset-blockchain branch from 8842316 to 789b1d0 Compare January 2, 2019 18:02

niklasad1 reviewed Jan 3, 2019

View reviewed changes

ethcore/src/blockchain/blockchain.rs Outdated Show resolved Hide resolved

niklasad1 reviewed Jan 3, 2019

View reviewed changes

niklasad1 approved these changes Jan 3, 2019

View reviewed changes

seunlanlege and others added 10 commits January 16, 2019 12:24

show block hashes to be deleted and new best block, update best block…

cb7f1f8

… in db, better cli interface

delete BlockNumber from COL_EXTRA

03c6902

add TODO comment

6fba61e

add BlockReciepts to imports

44c37df

refactor block_headers_from_best_block, better cli documentation

8feb8ea

exit gracefully if reset arg isn't supplied

43e170e

fix cli usage macro

622b9ae

removed stray int literals

8bd6ad6

use Vec::with_capacity

68c4815

Co-Authored-By: seunlanlege <seunlanlege@gmail.com>

cast n to usize

4c1fe75

seunlanlege force-pushed the reset-blockchain branch from b88c149 to 4c1fe75 Compare January 16, 2019 08:26

correct imports

0847a36

tomusdrw approved these changes Jan 16, 2019

View reviewed changes

parity/cli/mod.rs Outdated Show resolved Hide resolved

make db reset arg required

cb7b71f

5chdn merged commit cdba22a into master Jan 16, 2019

5chdn deleted the reset-blockchain branch January 16, 2019 15:37

5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Jan 16, 2019

sorpaas reviewed Jan 16, 2019

View reviewed changes

HCastano mentioned this pull request Feb 12, 2019

Backports for Beta 2.3.3 #10333

Merged

18 tasks

ordian mentioned this pull request Feb 12, 2019

Fix Beta Backports #10337

Closed

jam10o-new mentioned this pull request Feb 18, 2019

Rollback database to the specific block/hash (cli command) #4324

Closed

This was referenced Jun 1, 2019

void #10708

Closed

void poanetwork/parity-ethereum#143

Closed

ghost mentioned this pull request Jun 11, 2019

void #10712

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds cli interface to allow reseting chain to a particular block #9782

Adds cli interface to allow reseting chain to a particular block #9782

seunlanlege commented Oct 19, 2018

parity-cla-bot commented Oct 19, 2018

5chdn commented Dec 14, 2018

seunlanlege commented Dec 17, 2018

tomusdrw commented Dec 17, 2018

seunlanlege commented Dec 17, 2018

5chdn commented Dec 28, 2018

tomusdrw left a comment

niklasad1 Jan 3, 2019

seunlanlege Jan 3, 2019

seunlanlege Jan 3, 2019

niklasad1 left a comment

tomusdrw left a comment

5chdn commented Jan 16, 2019

sorpaas Jan 16, 2019

stone212 commented Jan 25, 2020

zemse commented May 1, 2020

dvdplm commented May 1, 2020

astudnev commented Jun 1, 2020

Adds cli interface to allow reseting chain to a particular block #9782

Adds cli interface to allow reseting chain to a particular block #9782

Conversation

seunlanlege commented Oct 19, 2018

parity-cla-bot commented Oct 19, 2018

5chdn commented Dec 14, 2018

seunlanlege commented Dec 17, 2018

tomusdrw commented Dec 17, 2018

seunlanlege commented Dec 17, 2018

5chdn commented Dec 28, 2018

tomusdrw left a comment

Choose a reason for hiding this comment

niklasad1 Jan 3, 2019

Choose a reason for hiding this comment

seunlanlege Jan 3, 2019

Choose a reason for hiding this comment

seunlanlege Jan 3, 2019

Choose a reason for hiding this comment

niklasad1 left a comment

Choose a reason for hiding this comment

tomusdrw left a comment

Choose a reason for hiding this comment

5chdn commented Jan 16, 2019

sorpaas Jan 16, 2019

Choose a reason for hiding this comment

stone212 commented Jan 25, 2020

zemse commented May 1, 2020

dvdplm commented May 1, 2020

astudnev commented Jun 1, 2020