This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
A8-backport 🕸
Pull request is already reviewed well in another branch.
M4-core ⛓
Core client code / Rust.
M2-config 📂
Chain specifications and node configurations.
labels
Oct 20, 2018
5chdn
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Oct 23, 2018
It wasn't merged on purpose (it is not needed when we have #9657), see #9780 (comment), but still suggested for backports (could help with #9102).
No, #9638 fixed problems of #9433, both I believe were merged in 2.1.x (and they're unrelated to #9615), so no need to backport it. |
* removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change
* Allow zero chain id in EIP155 signing process * Rename test * Fix test failure
sorpaas
approved these changes
Oct 27, 2018
andresilva
approved these changes
Oct 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-pleasereview 🤓
Pull request needs code review.
A8-backport 🕸
Pull request is already reviewed well in another branch.
M2-config 📂
Chain specifications and node configurations.
M4-core ⛓
Core client code / Rust.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent zero networkID (prevent zero networkID #9763)??