Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backport Beta 2.2.1 #9905

Merged
merged 20 commits into from
Nov 14, 2018
Merged

Backport Beta 2.2.1 #9905

merged 20 commits into from
Nov 14, 2018

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Nov 13, 2018

@Tbaut Tbaut added A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. M2-config 📂 Chain specifications and node configurations. labels Nov 13, 2018
@Tbaut Tbaut added the A0-pleasereview 🤓 Pull request needs code review. label Nov 13, 2018
mattrutherford and others added 4 commits November 13, 2018 10:34
* Fix json tracer overflow

* Replace trace_executed with a direct trace push

* Remove unused variable

* Add test for 5a51

* Remove duplicate json!
* Dockerfile: change source path of the newly added check_sync.sh (#9869)
@ascjones
Copy link
Contributor

@Tbaut looks like #9108 was already merged in #9094

cheme and others added 5 commits November 13, 2018 10:58
* Allow to seal work on latest block.

* Test from @todr to check sealing conditions.
* use docker cargo config file for android builds

* make android build succeed
* ethcore: use Machine::verify_transaction on parent block

also fixes off-by-one activation of transaction permission contract

* ethcore: clarify call to verify_transaction
seunlanlege and others added 6 commits November 14, 2018 09:06
* EIP-712 impl

* added more tests

* removed size parsing unwrap

* corrected TYPE_REGEX to disallow zero sized fixed length arrays, replaced LinkedHashSet with IndexSet, added API spec to docs, fixed Type::Byte encoding branch

* use Option<u64> instead of u64 for Type::Array::Length

* replace `.iter()` with  `.values()`

Co-Authored-By: seunlanlege <seunlanlege@gmail.com>

* tabify eip712.rs

* use proper comments for docs

* Cargo.lock: revert unrelated changes

* tabify encode.rs
* added sign_191 rpc method

* fixed hash_structured_data return type

* added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191

* renamed WithValidator -> PresignedTransaction

* rename applicationData to data in test

* adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest
…quired gas from response on failure (#9824)

* fix start_gas, handle OOG exceptions & NotEnoughGas

* Change START_GAS: 50_000 -> 60_000
* When the `OutOfGas exception` is received then try to double the gas until it succeeds or block gas limit is reached
* When `NotEnoughBasGas error` is received then use the required gas provided in the response

* fix(light-fetch): ensure block_gas_limit is tried

Try the `block_gas_limit` before regard the execution as an error

* Update rpc/src/v1/helpers/light_fetch.rs

Co-Authored-By: niklasad1 <niklasadolfsson1@gmail.com>
Will go without cache. Meanwhile have to investigate what was wrong and how to use it effectively.
@Tbaut Tbaut merged commit 5c56fc5 into beta Nov 14, 2018
@ordian ordian deleted the Tbaut-beta-221 branch November 14, 2018 14:25
@5chdn 5chdn added this to the Patch milestone Nov 25, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 25, 2018
@5chdn
Copy link
Contributor

5chdn commented Nov 25, 2018

Good work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.