This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add tokio runtime to ethcore io worker #9979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grbIzl
added
A0-pleasereview 🤓
niklasad1
reviewed
Nov 28, 2018
niklasad1
reviewed
Nov 28, 2018
niklasad1
approved these changes
Nov 28, 2018
niklasad1
added
A6-mustntgrumble 💦
niklasad1
reviewed
Nov 28, 2018
| use std::sync::Arc; | ||
| use std::thread::{JoinHandle, self}; | ||
| use std::sync::atomic::{AtomicBool, Ordering as AtomicOrdering}; | ||
| use deque; | ||
| use service_mio::{HandlerId, IoChannel, IoContext}; | ||
| use tokio::{self}; |
There was a problem hiding this comment.
I guess it is safer to keep this self to be backward compatible but these are not needed since Rust 1.30
ordian
reviewed
Nov 28, 2018
grbIzl
force-pushed
the
TobalabaPrivateFixes
branch
from
8563449
to
8a5daa0
Compare
grbIzl
added
A0-pleasereview 🤓
sorpaas
approved these changes
Dec 3, 2018
sorpaas
added
A8-looksgood 🦄
niklasad1
pushed a commit
that referenced
this pull request
Dec 16, 2018
* Add tokio runtime to ethcore io worker * Reworked with block_on_all
insipx
pushed a commit
to insipx/parity-ethereum
that referenced
this pull request
Dec 17, 2018
* Add tokio runtime to ethcore io worker * Reworked with block_on_all
This was referenced Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9657 it's assumed, that all threads initialize tokio runtime, if they want to use tokio functionality (like timers). In particular the following scenario was broken:
As ethcore io worker doesn't initialize the runtime, sending the request fails.
I believe, that this problem can occur not only for private transaction scenario