Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-207: Drupal Module template creation. #3

Merged
merged 23 commits into from
Mar 1, 2018
Merged

Conversation

voidtek
Copy link
Member

@voidtek voidtek commented Feb 27, 2018

No description provided.

sandervd and others added 20 commits February 8, 2018 13:45
OPENEUROPA-207: Update name database.

OPENEUROPA-207: Update syntaxe info file.

OPENEUROPA-207: Change the travis yml.

OPENEUROPA-207: Change the travis yml.
OPENEUROPA-207: Changes parameters.

OPENEUROPA-207: Changes the user for docker in travis.

Revert "OPENEUROPA-207: Changes the user for docker in travis."

This reverts commit eea49cf.

OPENEUROPA-207: Simplify travis file.
OPENEUROPA-207: Add 8.5.x-dev to test.
OPENEUROPA-207: Improve travis file.
OPENEUROPA-207: Test all travis.

OPENEUROPA-207: Add behat dependencies.

OPENEUROPA-207: Remove test autoloaders.

OPENEUROPA-207: Resolve travis issues.

OPENEUROPA-207: Resolve travis issues.

OPENEUROPA-207: Update version of docker-compose and add full matrix of version of drupal.

OPENEUROPA-207: Remove drupal 8.4.x on the travis matrix.
@pfrenssen
Copy link
Member

Closing in favor of #1 which has the original review comments.

@pfrenssen pfrenssen closed this Feb 27, 2018
@pfrenssen pfrenssen deleted the OPENEUROPA-207 branch February 27, 2018 12:52
@pfrenssen pfrenssen reopened this Feb 27, 2018
@pfrenssen
Copy link
Member

Reopening, it wasn't possible to reopen PR #1. This repo was created with an empty master branch, with the intention that PR #1 would become the root, but in the meantime #2 was merged, causing the root to change and now #1 no longer shares a base with master and cannot be reopened.

Please refer to #1 for the related discussion for this PR.

@pfrenssen
Copy link
Member

Tests are failing because of docker related errors. I had the same problem in OE Paragraphs, the only way I got the tests to run reliably was by disabling docker.

Here's the commit that fixed it: openeuropa/oe_paragraphs@b4496a1

@pfrenssen
Copy link
Member

The test was restarted on Travis and again it fails, this time because of the commit depth, this is also something that I have already solved in openeuropa/oe_paragraphs@b4496a1

@voidtek
Copy link
Member Author

voidtek commented Feb 27, 2018

I found a solution for this recurrent issue on travis and docker. I am testing my solution in another branch and I run the build several times (10 times) If the issue does not appear again, I push my solution on this branch.

@ademarco
Copy link
Member

We should start using EUPL-1.2 on all our projects, @voidtek could you update it please? Thanks!

@voidtek voidtek merged commit cbca738 into master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants