EWPP-1146: Update test coverage for template prefixes. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademarco
requested changes
Jun 15, 2021
ademarco
requested changes
Jun 16, 2021
| * Twig extension, defaults to ".html.twig". | ||
| */ | ||
| public function __construct($namespaces, $paths = [], $root = null, $prefix = 'twig-component-', $templatePrefix = '', $extension = '.html.twig') | ||
| public function __construct($namespaces, $paths = [], string $root = null, string $prefix = 'twig-component-', string $templatePrefix = '', string $extension = '.html.twig') |
There was a problem hiding this comment.
Let's not add string typing here and below, as we didn't do it anywhere else in the class.
| * | ||
| * @dataProvider dataProvider | ||
| */ | ||
| public function testLoader($name, $expected, $prefix) | ||
| public function testLoader(string $name, string $expected, string $prefix, string $templatePrefix) |
There was a problem hiding this comment.
Same as above, let's not add typing.
ademarco
approved these changes
Jun 21, 2021
imanoleguskiza
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.