Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-2724: Bubble up facet cache. #163

Merged
merged 8 commits into from
Jan 27, 2023
Merged

EWPP-2724: Bubble up facet cache. #163

merged 8 commits into from
Jan 27, 2023

Conversation

nagyad
Copy link
Member

@nagyad nagyad commented Nov 16, 2022

No description provided.

@hernani hernani force-pushed the EWPP-2724 branch 2 times, most recently from 1028775 to 0bee9da Compare December 21, 2022 11:01
Copy link
Contributor

@upchuk upchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no tests for any of these changes.

src/EventSubscriber/QuerySubscriber.php Outdated Show resolved Hide resolved
Copy link
Member

@hernani hernani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

tests/src/Kernel/ListBuilderTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/DateStatusTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/DateStatusTest.php Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@nagyad nagyad merged commit 300e5ca into master Jan 27, 2023
@nagyad nagyad deleted the EWPP-2724 branch January 27, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants