EWPP-2630: Search support for europa search api backend #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernani
force-pushed
the
EWPP-2630
branch
4 times, most recently
from
581f176
to
6cc8688
Compare
hernani
force-pushed
the
EWPP-2630
branch
3 times, most recently
from
4336506
to
f122d58
Compare
hernani
force-pushed
the
EWPP-2630
branch
4 times, most recently
from
46bf021
to
977f2d2
Compare
hernani
force-pushed
the
EWPP-2630
branch
7 times, most recently
from
1e8beaa
to
b6a1412
Compare
upchuk
requested changes
Nov 14, 2022
src/EntityMapper.php
Outdated
| $entity->in_preview = TRUE; | ||
| // Allow event subscribers to alter the created entity. | ||
| $event = new EuropaEntityCreationEvent($entity, $metadata, $query); | ||
| $this->eventService->dispatch($event); |
There was a problem hiding this comment.
Where is the event name? It's not a valid event dispatching.
Also, let's name the variable eventDispatcher isntead of event service.
hernani
force-pushed
the
EWPP-2630
branch
4 times, most recently
from
4d99e57
to
0257466
Compare
upchuk
requested changes
Nov 15, 2022
sergepavle
reviewed
Nov 15, 2022
sergepavle
reviewed
Nov 16, 2022
sergepavle
reviewed
Nov 22, 2022
sergepavle
previously approved these changes
Nov 23, 2022
upchuk
approved these changes
Nov 28, 2022
sergepavle
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands