Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-309: Add OE Whitelabel theme scaffold files. #1

Merged
merged 25 commits into from
Sep 7, 2021
Merged

OEL-309: Add OE Whitelabel theme scaffold files. #1

merged 25 commits into from
Sep 7, 2021

Conversation

10atm-blue
Copy link
Contributor

PR goals:

  • Add Whitelabel theme file structure

drishu
drishu reviewed Aug 26, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2 <-- click me

@drishu drishu self-requested a review August 30, 2021 08:55
drishu
drishu requested changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was to fast

claudiu-cristea
claudiu-cristea suggested changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo approval.

drishu
drishu previously approved these changes Sep 7, 2021
View reviewed changes
abel-santos-corral
abel-santos-corral approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@abel-santos-corral abel-santos-corral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all files. File .phpunit.result.cache eliminated from git and added to .gitignore file. Also checked the assets.

.phpunit.result.cache Outdated
@@ -0,0 +1 @@
{"version":1,"defects":[],"times":[]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file must be eliminated.

@claudiu-cristea claudiu-cristea merged commit 1e275c5 into 1.x Sep 7, 2021
@claudiu-cristea claudiu-cristea deleted the OEL-309 branch September 7, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiu-cristea claudiu-cristea claudiu-cristea approved these changes

@drishu drishu drishu approved these changes

@abel-santos-corral abel-santos-corral abel-santos-corral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@10atm-blue @claudiu-cristea @drishu @abel-santos-corral @GilNovacomm