OEL-455 [oe_whitelabel] footer #10
Conversation
composer.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "drupal/core": "^8.9 || ^9.1", | |||
| "drupal/ui_patterns": "^1.0", | |||
| "drupal/ui_patterns_settings": "^1.0", | |||
| "openeuropa/oe_corporate_blocks": "^4.2", | |||
There was a problem hiding this comment.
Let's move this to require dev as it's not needed by the theme, but by the module
| package: OpenEuropa Whitelabel Theme | ||
| core_version_requirement: ^8.9 || ^9.1 | ||
| dependencies: | ||
| - openeuropa:oe_corporate_blocks |
There was a problem hiding this comment.
Since Francesco asked to use a helper module, and now we have it, lets move the dependency in there, we can remove this then
runner.yml.dist
Outdated
| post_install: | ||
| # Prepare the instance. | ||
| - "./vendor/bin/drush en ui_patterns ui_patterns_library ui_patterns_settings components -y" | ||
| - "./vendor/bin/drush en oe_whitelabel_footer -y" |
There was a problem hiding this comment.
now that its a dependency on helper, we can remove this
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getFilters(): array { |
|
|
||
| return $ecl_links; | ||
| } | ||
|
|
There was a problem hiding this comment.
add a block renderer, we will use it for the corporate logo in the block
| { | ||
| 'section_id': 'eu_footer_left', | ||
| 'logo': 'logo', | ||
| 'path': url('<front>') |
| 'logo': 'logo', | ||
| 'path': url('<front>') | ||
| },{ | ||
| 'section_id': 'eu_footer_middle', |
There was a problem hiding this comment.
move all this to a new bottom_section
| }, | ||
| { | ||
| 'section_id': 'eu_footer_right', | ||
| 'eu_institutions_title': corporate_footer.institution_links_title, |
There was a problem hiding this comment.
move all this to a new bottom_section
|
|
||
|
|
||
| ] %} | ||
|
|
| ] %} | ||
|
|
||
| {{ pattern('footer', { | ||
| 'top_sections': _top_sections |
| @@ -0,0 +1,39 @@ | |||
| <footer> | |||
There was a problem hiding this comment.
the container from page does the job, this footer tag is redundant and so is below container
tests/src/Kernel/FooterBlockTest.php
Outdated
| 'block', | ||
| 'components', | ||
| 'oe_whitelabel_helper', | ||
| 'oe_whitelabel_footer', |
| * {@inheritdoc} | ||
| */ | ||
| protected static $modules = [ | ||
| 'block', |
There was a problem hiding this comment.
you are missing the oe_corporate_blocks and its dependencies
tests/src/Kernel/FooterBlockTest.php
Outdated
| /** | ||
| * Tests the EU and the EC corporate Footer blocks rendering. | ||
| */ | ||
| class FooterBlockTest extends KernelTestBase { |
There was a problem hiding this comment.
this needs to be SparqlKernelTestBase
Manage oe_whitelabel footer blocks for EU and EC.