Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: OEL-1255: Migrate paragraphs #105

Merged
merged 56 commits into from
Apr 6, 2022
Merged

EPIC: OEL-1255: Migrate paragraphs #105

merged 56 commits into from
Apr 6, 2022

Conversation

donquixote
Copy link
Contributor

@donquixote donquixote commented Mar 29, 2022 •
edited
Loading

No description provided.

abel-santos-corral and others added 30 commits March 17, 2022 14:30
@abel-santos-corral
OEL-1280: Add modules at composer.json for oe_whitelabel_paragraphs.
5cbadae
@abel-santos-corral
OEL-1280: Add oe_whitelabel_paragraphs by copying oe_bootstrap_theme_…
280d105 
…paragraphs.

Rename strings where needed.
@abel-santos-corral
OEL-1280: Add templates of paragraphs.
1891f4f
@abel-santos-corral
OEL-1280: Add oe_whitelabel_paragraphs at runner.
4eb3cbe
@abel-santos-corral
OEL-1280: Add tests for oe_whitelabel_paragraphs.
2c89261
@abel-santos-corral
OEL-1280: Upgrade packages in composer.json.
79ab2f1 
Upgrade oe_content to 2.8.0 version.
Upgrade file_link to 2.6.0 version.
@abel-santos-corral
OEL-1280: Eliminate patch of oe_bootstrap_theme.
f8a807f
@abel-santos-corral
OEL-1280: Change the prefix of fields of paragraphs.
432cca2
@abel-santos-corral
OEL-1280: Set correct function prefix at oe_whitelabel_paragraphs.mod…
02678f9 
…ule.
@abel-santos-corral
OEL-1280: Add paragraphs.inc.
a343a16
@abel-santos-corral
OEL-1280: Add temporary release 0.1280.202203170900 into composer.
d8476b8
@abel-santos-corral
OEL-1280: Fix typos at name of hook_theme_suggestions_HOOK_alter.
b340533
@abel-santos-corral
OEL-1280: Rename hooks preprocess on behalf of oe_whitelabel theme.
5d357a8
@abel-santos-corral
OEL-1280: Rename inner functions at oe_whitelabel_paragraphs.module.
f05f64b
@abel-santos-corral
OEL-1280: Bring sections of paragraphs into README.md file.
f7c1ddf
@abel-santos-corral
OEL-1280: Add oe_whitelabel_helper.install to check paragraphs requir…
dbc02ef 
…ements.
@abel-santos-corral
OEL-1280: Reorder lists dependencies and install at oe_whitelabel_par…
abc87f5 
…agraphs.info.yml.
@abel-santos-corral
OEL-1280: Eliminate post_update file and related config folder.
e1bdf81
@abel-santos-corral
OEL-1280: Sort list configs and add missing element at oe_whitelabel_…
4fd7fda 
…paragraphs.install.
@abel-santos-corral
OEL-1280: Bring file field--entity-reference-revisions--paragraph.htm…
4615487 
…l.twig.
@donquixote
OEL-1280: Use latest version of oe_bootstrap_theme in epic.
efd8df0
@donquixote
Merge pull request #93 from openeuropa/OEL-1280
81071cc 
[OEL-1255] OEL-1280: Copy and rename paragraph submodule from oe_bootstrap_theme
@donquixote
Merge remote-tracking branch 'g/1.x' into update-EPIC-OEL-1255
712a543
@donquixote
Merge pull request #102 from openeuropa/update-EPIC-OEL-1255
4dc8989 
Merge 1.x into EPIC-OEL-1255-migrate-paragraphs.
@donquixote
OEL-1255: Bump oe_bootstrap_theme version.
c46f448
@donquixote
Merge remote-tracking branch 'origin/1.x' into update-EPIC-OEL-1255
f79cafd 
Conflicts:
Keep the oe_bootstrap_theme version from HEAD, it is already ahead of what's in MERGE_HEAD.
@donquixote
OEL-1042: Enable media_avportal_mock on ParagraphsTestBase, as previo…
33159f5 
…usly in oe_paragraph_theme.
@donquixote
Merge pull request #103 from openeuropa/update-EPIC-OEL-1255
b0cb132 
Merge 1.x into EPIC-OEL-1255-migrate-paragraphs, and up oebt version.
@donquixote
OEL-1281: Add upgrade path from oe_bootstrap_theme_paragraphs.
c84d32a
@donquixote
OEL-1281: Add test for upgrade path.
17cee2b 
Example code found here:
https://git.drupalcode.org/project/nopremium/-/blob/8.x-1.x/tests/src/Functional/InstallTest.php
donquixote and others added 25 commits March 29, 2022 18:41
@donquixote
OEL-1281: Remove useless config in test module.
b2eea8b
@donquixote
OEL-1281: Remove config_devel entries in test module.
55e080f
@donquixote
OEL-1281: Clean up and reorder dependencies for test module.
d7fa5d6
@donquixote
OEL-1281: Document assertion strategy in InstallTest.
12c59b9
@donquixote
OEL-1281: Use local variable instead of inline evaluation in foreach.
474712b
@donquixote
OEL-1281: Use static mapping for legacy fields map, change defensive …
657963c 
…code.

This is simpler, and prevents the operation to run on unknown paragraph types.
@donquixote
OEL-1281: Drop useless comment lines.
1b05cef
@donquixote
OEL-1281: Drop defensive code for impossible cases.
351d80d 
Use `@var` doc to document that variable won't be NULL.
@donquixote
OEL-1042: Rename $definition -> $field_config.
ca45095
@donquixote
OEL-1281: Throw RuntimeException in unexpected scenarios.
5526a4c
@donquixote
OEL-1281: Rename variables $field_name(s) -> $legacy_field_name(s).
46f29b3
@donquixote
OEL-1281: Don't use injected services in tests, remove unnecessary as…
95b6e68 
…sertions.
@donquixote
OEL-1281: Use $this->assert*() instead of self::assert*(), as in core.
1d8b417
@donquixote
OEL-1281: Test one of the paragraphs with an older revision.
f97f806
@donquixote
OEL-1281: Test config deletion explicitly.
0636d87
@donquixote
OEL-1281: Don't use fully-qualified name for global functions.
e9cbd0e
@donquixote
Merge pull request #97 from openeuropa/OEL-1281
1db80f9 
[OEL-1255] OEL-1281: Upgrade path from oe_bootstrap_theme_paragraphs
@donquixote
OEL-1283: Add upgrade instructions for oe_whitelabel_paragraphs module.
eb63462
@donquixote
OEL-1283: Remove redundant info from README, but add some more useful…
c11122c 
… hints.
@donquixote
OEL-1283: Upgrade to x, instead of upgrade from x, in README.
742f927
@donquixote @brummbar
OEL-1283: Change wording for update hook.
6082781 
Co-authored-by: Francesco <brummbar@users.noreply.github.com>
@brummbar
Merge pull request #99 from openeuropa/OEL-1283
c5860ca 
OEL-1283: Add update instructions for paragraphs move.
@donquixote
Merge remote-tracking branch 'g/1.x' into update-EPIC-OEL-1255
af1742d
@donquixote
OEL-1255: Patch oe_bootstrap_theme for latest 1.x.
9fe40b4
@donquixote
Merge pull request #113 from openeuropa/update-EPIC-OEL-1255
d9ba335 
Merge 1.x into EPIC-OEL-1255-migrate-paragraphs
drishu
drishu approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, and is ok, had to:

  • make sure the news and events are not enabled before
  • enable the new modules oe_whitelabel_multilingual and oe_whitelabel_paragraphs after updb

@donquixote donquixote merged commit 7b8b9c6 into 1.x Apr 6, 2022
@donquixote donquixote deleted the EPIC-OEL-1255-migrate-paragraphs branch April 6, 2022 08:55
@AaronGilMartinez AaronGilMartinez mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brummbar brummbar brummbar approved these changes

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donquixote @brummbar @drishu @abel-santos-corral