Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1374: Search page look & feel update #126

Merged
merged 30 commits into from
May 12, 2022
Merged

OEL-1374: Search page look & feel update #126

merged 30 commits into from
May 12, 2022

Conversation

escuriola
Copy link
Contributor

oe_whitelabel.theme Outdated Show resolved Hide resolved
templates/overrides/page/page.html.twig Show resolved Hide resolved
templates/overrides/page/page.html.twig Outdated Show resolved Hide resolved
modules/oe_whitelabel_search/oe_whitelabel_search.module Outdated Show resolved Hide resolved
oe_whitelabel.theme Outdated Show resolved Hide resolved
modules/oe_whitelabel_search/oe_whitelabel_search.module Outdated Show resolved Hide resolved
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining issues should be fixed

drishu
drishu previously approved these changes Apr 28, 2022
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, lets not block it for some comments

drishu
drishu previously approved these changes May 2, 2022
Maxfire
Maxfire previously approved these changes May 4, 2022
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check also the not fixed newline, thx

drishu
drishu previously approved these changes May 12, 2022
@escuriola escuriola merged commit 7fff71e into 1.x May 12, 2022
@escuriola escuriola deleted the OEL-1374 branch May 12, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants