Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-1585: Fix logo url link in neutral flavour and test coverage. #142

Merged
merged 1 commit into from
May 19, 2022
Merged

OEL-1585: Fix logo url link in neutral flavour and test coverage. #142

merged 1 commit into from
May 19, 2022

Conversation

escuriola
Copy link
Contributor

No description provided.

brummbar
brummbar requested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@brummbar brummbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I suggested to use front_page is because of this:

image

It will make more clear that we are pointing to the front_page and that variable is ready already.

@escuriola escuriola merged commit 8e2bb1b into 1.x May 19, 2022
@escuriola escuriola deleted the OEL-1585 branch May 19, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brummbar brummbar brummbar approved these changes

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escuriola @brummbar @drishu