OEL-1540: Fix Scrollspy js file requirement when there is no items to display. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donquixote
reviewed
Jun 3, 2022
donquixote
reviewed
Jun 3, 2022
donquixote
previously approved these changes
Jun 3, 2022
drishu
requested changes
Jun 7, 2022
drishu
reviewed
Jun 7, 2022
| content: inpage_navigation_fields, | ||
| full_layout: true, | ||
| }) }} | ||
| {% if inpage_navigation_links is empty and description_items is not empty %} |
There was a problem hiding this comment.
actually drop the commit that does this description_items check, was my mistake
escuriola
force-pushed
the
OEL-1540
branch
2 times, most recently
from
907e957
to
b02b7bb
Compare
drishu
previously approved these changes
Jun 9, 2022
donquixote
previously approved these changes
Jun 9, 2022
…ntent only or full inpage_navigation pattern.
drishu
approved these changes
Jun 9, 2022
donquixote
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.