OEL-1552: Theme the person content type

[escuriola]

No description provided.

[donquixote]

A little bit of feedback.

[brummbar]

Let's make sure we followup on why the email icon for the socials is not showing. I think we need the BCL update for that, so it's fine for now.

[brummbar]

We have some work to do in a followup to prevent showing field labels when access to media entities is removed, but for now it looks good, just one comment in the tests.

[donquixote]

Left-over double quote.

Suggested change

	<div{{ not loop.last ? ' class="mb-3"' }}">
	<div{{ not loop.last ? ' class="mb-3"' }}>

[donquixote]

As above:
Why do we need this div with mb-3 at all?
The documents already have mt-4.
On the other hand: Imo this mt-4 from pattern-file.html.twig is questionable, so we could discuss if we really need it.

[escuriola]

I add because it was in the ewcms template and francesco ask to do the same.

[escuriola]

I remove the left-over double quote.
For the class you mention, I follow what Francesco said about to take the same ewcms has. I think that as long as we don't have the final designs we can leave it like this

[donquixote]

I would need to look at ewcms, no time for this unless you provide a link :)
But ok to keep until we get updated design.

[donquixote]

(tbd, don't implement directly)

Now we call this 3x, before each return.
We are not adding anything else to the $cacheability, so we could do it just once and avoid code repetition.

Suggested change

	if (!$access->isAllowed()) {
	$cacheability->applyTo($variables);
	$cacheability->applyTo($variables);
	if (!$access->isAllowed()) {

and then remove the other calls below.

Of course this only works if we don't add anything else to the $cacheability later.

[donquixote]

We have to change this back once we introduce image styles.
So maybe keep it for now? @drishu

[escuriola]

Any news here @drishu @donquixote

[donquixote]

Keep it for next reviewer.

[drishu]

agreed @donquixote, we need to code for what we have, and lets also remove the empty line 70

[escuriola]

I'm not sure but IMHO, this is not a blocker for this task, we have more or less the same in all the CT, so we should create a new ticket and do the fix everywhere and not block this ticket anymore, it's a ticket with a high priority to do this improvement now.

[donquixote]

Please check if social_links is empty. Otherwise we get an empty div here.

[donquixote]

The condition needs to be outside the wrapper div.

[donquixote]

As above:
Why do we need this div with mb-3 at all?
The documents already have mt-4.
On the other hand: Imo this mt-4 from pattern-file.html.twig is questionable, so we could discuss if we really need it.

[donquixote]

Currently the title is closer to the document or group above than the one it acts as a label for.
What should we do here? TBD.

[donquixote]

Let's keep it until we get an updated spec for these document groups.

[donquixote]

Still awkward, but I don't have a good counter proposal.
Let's keep it, unless @drishu has a better idea during second review.
(see also the other field templates)

[drishu]

My proposal is less scientific but more humane and understandable
"Field template of the Document reference entity."
We use the label not machine name this way we can understand.

But @donquixote has to agree first, if not we leave as is

[donquixote]

Actually this was Carlos first version, just in lowercase.
My initial request here was to include the field name, bundle and entity type, so we describe what we target.
But it is hard to put that into a single line.

One option would be to put these explanations in a separate block below:

Suggested change

	* Field template of the oe_document_reference for the oe_document document.
	* Template for the 'Document' field in the 'Document reference' entity type.
	*
	* Entity type: 'oe_document_reference'.
	* Field: 'oe_document'.
	* Bundle: 'oe_document'.

Another option is to keep the comment simple and not have it include all the info, and instead we expect the reader to check the template name.
Tbh, I would not trust the comment anyway.

But, here, we actually can squeeze it into one line!

Suggested change

	* Field template of the oe_document_reference for the oe_document document.
	* Template for the 'Document' field in the 'Document' document reference type.

[drishu]

ok

[donquixote]

The assertions for document group don't go very deep. But maybe it's enough.
Let's keep it unless @drishu complains in next review.

[drishu]

we should be using https://github.com/openeuropa/oe_bootstrap_theme/blob/1.x/tests/src/PatternAssertion/FilePatternAssert.php

[donquixote]

The condition needs to be outside the wrapper div.

[donquixote]

Keep it for next reviewer.

[donquixote]

github is weird.
I just submitted the review only by refreshing the browser window, without using the control at the top right.
Anyway, the comments do appear so let's go.

[donquixote]

Suggested change

	* Field template of the oe_document_reference for the oe_document_group document.
	* Template for 'Documents' field in 'Document group' document reference type.

(omitting the 'the' to keep the line character limit)

[donquixote]

Suggested change

	* Field template of the oe_document_reference for the oe_document_group title.
	* Template for the 'Title' field in 'Document group' document reference type.

[drishu]

Let's follow up on the remaining issues

[drishu]

Approved, we convened on follow up tickets