OEL-1326: Cleaning patterns & paragraphs from OEL-755 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
previously approved these changes
Jul 11, 2022
donquixote
previously approved these changes
Jul 18, 2022
| @@ -174,7 +168,6 @@ protected function createListItems(File $image_file, Node $node): array { | |||
| 'alt' => 'Alt for image ' . $i, | |||
| 'target_id' => $image_file->id(), | |||
| ], | |||
| 'field_oe_date' => '2011-11-13', | |||
There was a problem hiding this comment.
From the other PR oe_bootstrap_theme:191:
you don't need all this, you'r not asserting the paragraph content in this test, and that is ok, you don't need date, you dont need image, you dont need most, add just minimal and use a random function instead where needed
There was a problem hiding this comment.
Not sure if anything else should be removed here. But I am going to assume it is ok.
drishu
previously approved these changes
Jul 29, 2022
donquixote
previously approved these changes
Jul 29, 2022
…also some asserts with estetical classes.
Multiple tickets were merged in oe_bootstrap_theme but not the corresponding in whitelabel.
brummbar
approved these changes
Aug 5, 2022
drishu
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1326