-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-1326: Cleaning patterns & paragraphs from OEL-755 #163
Conversation
@@ -174,7 +168,6 @@ protected function createListItems(File $image_file, Node $node): array { | |||
'alt' => 'Alt for image ' . $i, | |||
'target_id' => $image_file->id(), | |||
], | |||
'field_oe_date' => '2011-11-13', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the other PR oe_bootstrap_theme:191:
you don't need all this, you'r not asserting the paragraph content in this test, and that is ok, you don't need date, you dont need image, you dont need most, add just minimal and use a random function instead where needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if anything else should be removed here. But I am going to assume it is ok.
…also some asserts with estetical classes.
Multiple tickets were merged in oe_bootstrap_theme but not the corresponding in whitelabel.
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1326