OEL-1919: Fix broken styling for facetapi. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
commented
Aug 17, 2022
drishu
commented
Aug 17, 2022
| {%- if items -%} | ||
| <{{ list_type }}{{ attributes }}> | ||
| {%- for item in items -%} | ||
| <li{{ item.attributes.addClass('mb-2') }}>{{ item.value }}</li> |
There was a problem hiding this comment.
I lowered the margin here from mb-3 like in netlify to mb-2, also created a ticket to follow up
drishu
commented
Aug 17, 2022
| @@ -0,0 +1,10 @@ | |||
| <div{{ attributes }}> | |||
There was a problem hiding this comment.
not related to this template but was thinking of moving all templates from under /overrides into /templates
drishu
commented
Aug 17, 2022
brummbar
requested changes
Aug 18, 2022
| @@ -0,0 +1,4 @@ | |||
| .oel-facets-checkbox-list { | |||
There was a problem hiding this comment.
I think we can determine this by using the parent? .facets-widget-checkbox or due to line 9 in the twig, directly .item-list__checkbox.
drishu
commented
Aug 19, 2022
brummbar
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.