-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-1919: Fix broken styling for facetapi. #176
Conversation
{%- if items -%} | ||
<{{ list_type }}{{ attributes }}> | ||
{%- for item in items -%} | ||
<li{{ item.attributes.addClass('mb-2') }}>{{ item.value }}</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lowered the margin here from mb-3 like in netlify to mb-2, also created a ticket to follow up
@@ -0,0 +1,10 @@ | |||
<div{{ attributes }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this template but was thinking of moving all templates from under /overrides into /templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,4 @@ | |||
.oel-facets-checkbox-list { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can determine this by using the parent? .facets-widget-checkbox
or due to line 9 in the twig, directly .item-list__checkbox
.
No description provided.