OEL-1915: Add Date to the Event teaser. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
force-pushed
the
OEL-1915
branch
2 times, most recently
from
bae88ce
to
4ca0ec8
Compare
drishu
commented
Dec 19, 2022
| * @param array $variables | ||
| * Render array variables. | ||
| */ | ||
| function _oe_whitelabel_starter_event_preprocess_date(array &$variables): void { |
There was a problem hiding this comment.
I didn't create a formatter (even though I wanted to) because it would use the date_block pattern and that is not ready for date ranges, and updating that seems a lot of work out of scope (I'll prep a ticket for it).
brummbar
requested changes
Jan 6, 2023
| /** @var \Drupal\Core\Datetime\DrupalDateTime $end */ | ||
| $end = $dates->get('end_date')->getValue(); | ||
|
|
||
| if (!empty($end) && $start->format('d-m-y') !== $end->format('d-m-y')) { |
There was a problem hiding this comment.
Is it correct to show the year twice when it's the same?
Maybe it's something to ask the designers.
brummbar
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.