OEL-2115: Update to PHP 8.1 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
commented
Apr 18, 2023
composer.json
Outdated
| "drupal/description_list_field": "^1.0@alpha", | ||
| "drupal/drupal-extension": "~4.1", | ||
| "drupal/drupal-extension": "^5.0.0alpha1", |
There was a problem hiding this comment.
We actually don't need Behat, so we can drop this and keep core-dev.
| @@ -96,7 +96,7 @@ public function testEventPage(): void { | |||
|
|
|||
| $link = $crawler->filter('.bcl-content-banner a[href="/build/node/' . $node->id() . '"]'); | |||
| $this->assertCount(1, $link); | |||
| $this->assertObjectNotHasAttribute('target', $link); | |||
| $this->assertFalse(property_exists($link, 'target')); | |||
There was a problem hiding this comment.
Can't we just use ->getAttribute('href') ?
| $this->assertSame('http://localhost/bg/%3Cnone%3E', $link_language->attr('href')); | ||
| $this->assertEmpty($link_language->attr('href')); |
There was a problem hiding this comment.
Quite some weird old assertions here, was it a big bug?
There was a problem hiding this comment.
It's that change in drupal core rout matching, current_route_match for this Kernel test used to be <none> and after the code change its just empty
|
Looks good. |
drishu
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.