OEL-1771: Moved patterns tests from oe_whitelabel. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGilMartinez
requested changes
May 17, 2024
There was a problem hiding this comment.
Changes seems right but to make sure we need drone green and conflicts solved.
To get changes from oe_bootstrap_theme branch you can do:
composer require openeuropa/oe_bootstrap_theme:"dev-OEL-1771"
And then test all together, when bootstrap is released we can change composer to get new version.
Can you check both, please?
drishu
requested changes
May 27, 2024
drishu
reviewed
May 29, 2024
drishu
previously approved these changes
May 29, 2024
AaronGilMartinez
approved these changes
May 30, 2024
drishu
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.