Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-534: Counter to 0 included in the template. #28

Merged
merged 2 commits into from
Oct 11, 2021
Merged

OEL-534: Counter to 0 included in the template. #28

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a119d8
OEL-534: Counter to 0 included in the template.
Maxfire Oct 6, 2021
c829296
OEL-534: Uneeded condition removed.
Maxfire Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions templates/overrides/search/facets-summary-count.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@
* Default theme implementation to show facets summary count.
*/
#}
{% if count %}
<span class="source-summary-count">({{ count }})</span>
{% endif %}
{% set count = count ?? 0 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the result from our live total is 0 when it should be, then there is not point in this check

<span class="source-summary-count">({{ count }})</span>