OEL-450: Theme the site branding block. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-santos-corral
force-pushed
the
OEL-450
branch
from
6e0a3d8
to
8f04580
Compare
abel-santos-corral
force-pushed
the
OEL-450
branch
from
8f04580
to
56702b0
Compare
escuriola
previously approved these changes
Sep 7, 2021
drishu
requested changes
Sep 8, 2021
| @@ -0,0 +1,68 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Don't use a functional test just to check some classes and/or markup.
Please use something similar to https://github.com/openeuropa/oe_theme/blob/2.x/tests/Kernel/RenderingTest.php#L103
There was a problem hiding this comment.
in the end that one was incompatible with blocks
drishu
approved these changes
Sep 8, 2021
escuriola
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add twig to override block--system-branding-block and add classes to it.