OEL-1686: Updated tests regarding bcl-offcanvas duplicate class. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Aug 8, 2024
composer.json
Outdated
| @@ -27,6 +27,7 @@ | |||
| "drupal/extra_field": "^2.3", | |||
| "drupal/facets_form": "^1.0.0-alpha6", | |||
| "drupal/field_group": "^3.4", | |||
| "drupal/paragraphs": "1.17", | |||
There was a problem hiding this comment.
Suggested change
| "drupal/paragraphs": "1.17", | |
| "drupal/paragraphs": "~1.17.0", |
we need to lock it in such a way that it still permits patch releases
composer.json
Outdated
| @@ -107,7 +108,8 @@ | |||
| ] | |||
| }, | |||
| "_readme": [ | |||
| "Explicit requirement of nikic/php-parser ^4 as later versions are not compatible with grumphp @see https://github.com/phpro/grumphp/issues/1119" | |||
| "Explicit requirement of nikic/php-parser ^4 as later versions are not compatible with grumphp @see https://github.com/phpro/grumphp/issues/1119", | |||
| "Lock drupal/paragraphs to 1.17.x to apply patch correctly" | |||
There was a problem hiding this comment.
I dont understand from this message the exact reason, which patch?
drishu
approved these changes
Aug 8, 2024
AaronGilMartinez
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.