OEL-1017: [oe_whitelabel] Style the news content type #68
Conversation
…ontent display and date format configuration.
…ocess the media field for the content banner and card patterns.
…ate drone php version.
…sing the media field for cards.
GilNovacomm
force-pushed
the
OEL-1017
branch
2 times, most recently
from
776084e
to
a5009e6
Compare
…d ctools due to drupal 9.2 compatibility on lowest installation.
GilNovacomm
force-pushed
the
OEL-1017
branch
from
a5009e6
to
e54ff09
Compare
composer.json
Outdated
| @@ -6,29 +6,34 @@ | |||
| "minimum-stability": "dev", | |||
| "prefer-stable": true, | |||
| "require": { | |||
| "php": ">=7.3", | |||
| "php": ">=7.4", | |||
| "cweagans/composer-patches": "^1.7", | |||
| "drupal/core": "^8.9 || ^9.1", | |||
There was a problem hiding this comment.
We change to PHP 7.4 and don't change for drupal 9.2?
| type: module | ||
| description: Adds additional functionality to the News module | ||
| package: OpenEuropa Whitelabel Theme | ||
| core_version_requirement: ^8.9 || ^9.1 |
There was a problem hiding this comment.
Agreed. I've confirmed with Francesco we should update to D9.2
| * OE Whitelabel theme News. | ||
| */ | ||
|
|
||
| declare(strict_types=1); |
There was a problem hiding this comment.
| declare(strict_types=1); | |
| declare(strict_types = 1); |
| {% endset %} | ||
| {{ pattern('card', { | ||
| variant: 'search', | ||
| title: label, |
There was a problem hiding this comment.
| title: label, | |
| title: _title, |
| "drupal/drupal-extension": "~4.1", | ||
| "drupal/file_link": "^2.0.4", |
There was a problem hiding this comment.
why is needed?
- file_link, pathauto, email_validator?
There was a problem hiding this comment.
This issue is due to when installing the lowest versions:
Downgrading drupal/core (9.2.12 => 9.2.0): Loading from cache
these modules do not have the core_version_requirement key on their info file.
An explanation to each is on the _readme key on composer.json
"_readme": [ "Explicit minimum version requirement of drupal/ctools module due to D9.2 compatability.", "Explicit requirement for drupal/file_link due to https://www.drupal.org/project/file_link/issues/3147517. It can be removed when oe_media requires version 2.0.4 or above.", "Explicit requirement for drupal/pathauto due to D9.2 compatability according to https://www.drupal.org/node/2979476.", "Explicit requirement for egulias/email-validator due to https://www.drupal.org/project/drupal/issues/3061074#comment-14300579. It can be removed when Drupal core 9.2 support is droppped." ],
| * News full display. | ||
| */ | ||
| #} | ||
| {% set badges = [] %} |
There was a problem hiding this comment.
we need that? We can put badges: badges|render|default([])??
There was a problem hiding this comment.
Agreed it will clean the template and remove an unused array.
| * Search result template. | ||
| */ | ||
| #} | ||
| {% set badges = [] %} |
| '#value': content.oe_publication_date|render|striptags, | ||
| }, | ||
| badges: badges|render | ||
| }) }} |
| @@ -0,0 +1,7 @@ | |||
| langcode: und | |||
There was a problem hiding this comment.
How come this is und? Usually it's en
| langcode: und | ||
| status: true | ||
| dependencies: { } | ||
| id: oel_whitelabel_news_date |
| @@ -0,0 +1,13 @@ | |||
| name: OpenEuropa Whitelabel News | |||
| type: module | |||
| description: Adds additional functionality to the News module | |||
There was a problem hiding this comment.
The scope of the module is not to add additional functionality, but it's a companion module to provide the styling.
…eral improvements.
…and update display image assertion.
…filters from node display.
…date Functional test node view rendering.
Create oe_whitelabel_news submodule.
Create date format.
Configure full and teaser displays for the News content type.
Update required dependencies.
Create rendering tests.