Oel 454 search block pattern #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Sep 15, 2021
| label: "Action" | ||
| description: 'A url for attribute action' | ||
| preview: '#' | ||
| additional_classes: |
There was a problem hiding this comment.
also add additional classes for the input, the button
There was a problem hiding this comment.
additional classes for the button not available
| placeholder: | ||
| type: "text" | ||
| label: "Search" | ||
| preview: "search text" |
There was a problem hiding this comment.
add a field "additional_elements" of type array, in case more elements need to be injected
| } | ||
| %} | ||
| {% endif %} | ||
| <form{{ attributes.addClass('search-form', 'search-block-form', additional_classes) }} action="{{ url }}"> |
There was a problem hiding this comment.
create a attributes array
{% if attributes is empty %}
{% set attributes = create_attribute() %}
{% endif %}
start adding the classes, action to it, this way if the pattern sends more then the scenario is covered
| {# | ||
| /** | ||
| * @file | ||
| * Default theme implementation for a 'form' element. |
There was a problem hiding this comment.
Suggested change
| * Default theme implementation for a 'form' element. | |
| * Default theme implementation for a 'search form' composition. |
| 'label': button_label, | ||
| 'type': 'submit', | ||
| 'icon': _icon, | ||
| 'icon_position': 'after' |
There was a problem hiding this comment.
make the icon position configurable
drishu
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.