Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1291: News and Event content types renamed. #92

Merged
merged 9 commits into from
Mar 17, 2022
Merged

OEL-1291: News and Event content types renamed. #92

merged 9 commits into from
Mar 17, 2022

Conversation

Maxfire
Copy link
Contributor

@Maxfire Maxfire commented Mar 10, 2022

Content types renamed to make it work with oe_content, tests adapted.

composer.json Outdated
"openeuropa/oe_corporate_blocks": "^4.4",
"openeuropa/oe_multilingual": "^1.9",
"openeuropa/oe_starter_content": "1.x-dev",
"openeuropa/oe_starter_content": "dev-OEL-1290",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporal until this is merged.

drishu
drishu previously approved these changes Mar 11, 2022
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me, but adapt the PR once OEL-1290 is merged

escuriola
escuriola previously approved these changes Mar 11, 2022
escuriola
escuriola previously approved these changes Mar 14, 2022
drishu
drishu previously approved these changes Mar 14, 2022
Copy link
Contributor

@brummbar brummbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rename also the modules themselves.
Let's call oe_whitelabel_starter_news, oe_whitelabel_starter_event.
We need to rename the date format inside the news module.
I've found a problem with the changes in the featured media field, I'll reopen 1290.

@Maxfire Maxfire dismissed stale reviews from drishu and escuriola via 8af05f0 March 14, 2022 18:02
@brummbar brummbar added the epic The pull request represents an epic. label Mar 15, 2022
escuriola
escuriola previously approved these changes Mar 16, 2022
brummbar
brummbar previously approved these changes Mar 16, 2022
@Maxfire Maxfire merged commit 93aa607 into 1.x Mar 17, 2022
@Maxfire Maxfire deleted the OEL-1291 branch March 17, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic The pull request represents an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants