Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close res body #1836

Closed
wants to merge 1 commit into from
Closed

fix: close res body #1836

wants to merge 1 commit into from

Conversation

testwill
Copy link
Contributor

Description

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@testwill
fix: close res body
3f14731 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@alexellis
Copy link
Member

Hey @testwill please can you raise an issue for this showing what issue you found?

alexellis added a commit that referenced this pull request Apr 2, 2024
@alexellis
Remember to close HTTP body from response
667577f 
Flagged via community in:

#1836

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alex@openfaas.com>
@testwill
Copy link
Contributor Author

testwill commented Apr 2, 2024

Hello, you have fixed it. Do I still need to open an issue to record it?

@alexellis
Copy link
Member

Hi @testwill I saw another instance that needed to be updated. Thanks for flagging this.

For future PRs please raise an issue first 👍

@alexellis alexellis closed this Apr 3, 2024
@testwill testwill deleted the res_body_close branch April 3, 2024 15:51
jmikedupont2 pushed a commit to meta-introspector/faas that referenced this pull request Jul 25, 2024
@alexellis
Remember to close HTTP body from response
8c5808a 
Flagged via community in:

openfaas#1836

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alex@openfaas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @alexellis