This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Migrate to cert-manager 0.10.0 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format for Issuers, the solver config, and the annotations for Ingress all changed. This patch outputs the files in the new format. Unit tests were added for the new format, but full e2e testing needs to be done. Fixes: 122 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
There was an issue that caused two certificates to fight with each other - one created by Ingress shim and one by the bootstrap as a Certificate object, for the same domain. This patch moves away from using ingress-shim. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
There was a mis-match in the cert-manager docs, so these fields are actually no-longer required and stopped the cert from being created. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
|
@matipan @LucasRoesler @stefanprodan @ewilde @doowb @martindekov PTAL at the changeset. |
alexellis
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
The format for Issuers, the solver config, and the annotations
for Ingress all changed. This patch outputs the files in the
new format.
Fixes: 122
How Has This Been Tested?
Unit tests were added for the new format, but full e2e testing
needs to be done.
Users will need to upgrade as soon as possible to avoid known issues with the current cert-manager version being blocked by LetsEncrypt.
Checklist:
I have:
git commit -s