This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Add ECR support #133
Merged
Add ECR support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECR support is required for some customers and users. This patch also brings the of-builder over as a templated resource so that the AWS secret for accessing ECR can be bound when necessary to the register-image function and to the of-builder itself. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
A unique name is needed so that it doesn't clash with the secret created in the openfaas-fn namespace. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
openfaasltd/add-ecr
branch
from
9607641 to
6763fb4
Compare
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Tested e2e with the community cluster. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ECR support
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
ECR support is required for some customers and users. This patch
also brings the of-builder over as a templated resource so that
the AWS secret for accessing ECR can be bound when necessary
to the register-image function and to the of-builder itself.
How Has This Been Tested?
Automated e2e testing TBD, upstream feature tested through manual deployment.
Checklist:
I have:
git commit -s