Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Updrade to cert-manager 0.11.0 #140

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Updrade to cert-manager 0.11.0 #140

merged 1 commit into from
Oct 27, 2019

Conversation

Waterdrips
Copy link
Contributor

@Waterdrips Waterdrips commented Oct 27, 2019 •
edited
Loading

Description

We were pinned to cert-manager 0.10.0 before this update. There
has been a new release and we have upgraded to use 0.11.0 with its
new CRDs and new api namespace etc.

The 0.10.0 -> 0.11.0 update is a breaking change so the upgrade
instructions on the cert-manager website should be followed for
existing installs. New installs will use 0.11.0 by default

Signed-off-by: Alistair Hey alistair@heyal.co.uk
Closes #138

How Has This Been Tested?

Created a working installation init.yaml, then deleted cluster, upgraded the code components and then re-installed the application using the ofc-bootstrap script. Then verified that the installation was successful by building and running functions

Checklist:

I have:

  • checked my changes follow the style of the existing code / OpenFaaS repos
  • updated the documentation and/or roadmap in README.md
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@Waterdrips
Updrade to cert-manager 0.11.0
df2d729 
We were pinned to cert-manager 0.10.0 before this update. There
has been a new release and we have upgraded to use 0.11.0 with its
new CRDs and new api namespace etc.
The 0.10.0 -> 0.11.0 update is a breaking change so the upgrade
instructions on the cert-manager website should be followed for
existing installs. New installs will use 0.11.0 by default

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
@Waterdrips Waterdrips force-pushed the upgrade-certmanager-0.11.0 branch from 8d8cd75 to df2d729 Compare October 27, 2019 06:53
@alexellis
Copy link
Member

Created a working installation init.yaml, then deleted cluster, upgraded the code components and then re-installed the application using the ofc-bootstrap script. Then verified that the installation was successful by building and running functions

Did TLS work as expected after reinstalling? (you don't say)

alexellis
alexellis approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, waiting for some more details on the TLS testing results.

@Waterdrips
Copy link
Contributor Author

Created a working installation init.yaml, then deleted cluster, upgraded the code components and then re-installed the application using the ofc-bootstrap script. Then verified that the installation was successful by building and running functions

Did TLS work as expected after reinstalling? (you don't say)

Apologies - Yes works like a charm.

@alexellis alexellis merged commit 9557a67 into openfaas:master Oct 27, 2019
@alexellis
Copy link
Member

Noticed another typo in the PR and the commit (it's already been merged now though)

Updrade should be Upgrade

@Waterdrips Waterdrips deleted the upgrade-certmanager-0.11.0 branch November 2, 2019 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to cert-manager 0.11.0 from 0.10.0
2 participants
@Waterdrips @alexellis